Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OctInt/OctString function push down #6064

Closed
wants to merge 10 commits into from

Conversation

Ziy1-Tan
Copy link
Contributor

@Ziy1-Tan Ziy1-Tan commented Sep 29, 2022

What problem does this PR solve?

Implement OctInt/OctString function push down

Issue Number: close #5110
Related PR: pingcap/tidb#38316

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2022
@SeaRise SeaRise self-requested a review September 30, 2022 02:48
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2022
@Ziy1-Tan Ziy1-Tan marked this pull request as ready for review October 7, 2022 02:10
@ti-chi-bot ti-chi-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Oct 7, 2022
@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Oct 7, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Oct 7, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                      347               124    64.27%          45                 6    86.67%         638               240    62.38%         412               158    61.65%
Functions/FunctionsString.cpp                      1613               393    75.64%         307                75    75.57%        3474               828    76.17%        1000               321    67.90%
Functions/tests/gtest_strings_octint.cpp             36                14    61.11%           2                 0   100.00%         109                 0   100.00%           8                 8     0.00%
Functions/tests/gtest_strings_octstring.cpp          24                14    41.67%           2                 0   100.00%          47                 0   100.00%           8                 8     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              2020               545    73.02%         356                81    77.25%        4268              1068    74.98%        1428               495    65.34%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18407      7484             59.34%    215658  77113        64.24%

full coverage report (for internal network access only)

@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented Oct 8, 2022

/cc @SeaRise

@ywqzzy ywqzzy self-requested a review October 10, 2022 03:07
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
@Ziy1-Tan Ziy1-Tan requested review from ywqzzy and removed request for SeaRise October 10, 2022 03:40
@ywqzzy ywqzzy requested a review from SeaRise October 10, 2022 03:45
@ywqzzy ywqzzy self-requested a review October 10, 2022 11:15
@Ziy1-Tan
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Oct 11, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                      347               124    64.27%          45                 6    86.67%         638               240    62.38%         412               158    61.65%
Functions/FunctionsString.cpp                      1616               392    75.74%         307                75    75.57%        3478               826    76.25%        1002               320    68.06%
Functions/tests/gtest_strings_octint.cpp             53                14    73.58%           3                 0   100.00%         152                 0   100.00%           8                 8     0.00%
Functions/tests/gtest_strings_octstring.cpp          27                14    48.15%           3                 0   100.00%          67                 0   100.00%           8                 8     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              2043               544    73.37%         358                81    77.37%        4335              1066    75.41%        1430               494    65.45%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18413      7446             59.56%    215867  76508        64.56%

full coverage report (for internal network access only)

@Ziy1-Tan
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
@ti-chi-bot
Copy link
Member

@Ziy1-Tan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OctInt/OctString function push down
4 participants