Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expr): round decimal divide result when return type is Int512 #7035

Merged
merged 6 commits into from
Mar 10, 2023
Merged

fix(expr): round decimal divide result when return type is Int512 #7035

merged 6 commits into from
Mar 10, 2023

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Mar 10, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7022

Problem Summary:

part of #6471

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Mar 10, 2023
@LittleFall
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2023
windtalker
windtalker approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2023
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8fb5148

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2023
@LittleFall
Copy link
Contributor Author

[2023-03-10T09:33:14.405Z] fullstack-test/mpp/left_semi_family_joins.test: OK [5.853 s]

[2023-03-10T09:33:14.405Z] fullstack-test/mpp/misc_join.test: Running

[2023-03-10T09:33:16.924Z] fullstack-test/mpp/misc_join.test: OK [2.457 s]

[2023-03-10T09:33:16.924Z] fullstack-test/mpp/mpp_fail.test: Running

[2023-03-10T09:33:22.172Z] File: fullstack-test/mpp/mpp_fail.test

[2023-03-10T09:33:22.172Z] Error line: 35

[2023-03-10T09:33:22.172Z] Error: DBGInvoke get_active_threads_in_dynamic_thread_pool()

[2023-03-10T09:33:22.172Z] Result:

[2023-03-10T09:33:22.172Z] ┌─get_active_threads_in_dynamic_thread_pool()─┐

[2023-03-10T09:33:22.172Z] │ 1 │

[2023-03-10T09:33:22.172Z] └─────────────────────────────────────────────┘

[2023-03-10T09:33:22.172Z] Expected:

[2023-03-10T09:33:22.172Z] ┌─get_active_threads_in_dynamic_thread_pool()─┐

[2023-03-10T09:33:22.172Z] │ 0 │

[2023-03-10T09:33:22.172Z] └─────────────────────────────────────────────┘

@LittleFall
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit c6d55af into pingcap:master Mar 10, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #7040.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 10, 2023
@LittleFall @ti-chi-bot
This is an automated cherry-pick of pingcap#7035
956c73d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #7041.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 10, 2023
@LittleFall @ti-chi-bot
This is an automated cherry-pick of pingcap#7035
ad5aab9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #7042.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 10, 2023
@LittleFall @ti-chi-bot
This is an automated cherry-pick of pingcap#7035
4a0cbff 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 10, 2023
@LittleFall @ti-chi-bot
This is an automated cherry-pick of pingcap#7035
3f06d2b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7043.

@LittleFall LittleFall deleted the fix/7022 branch March 10, 2023 16:29
ti-chi-bot added a commit that referenced this pull request Mar 15, 2023
@ti-chi-bot
fix(expr): round decimal divide result when return type is Int512 (#7035
5ff1abc 
) (#7043)

close #7022
yibin87 added a commit that referenced this pull request Mar 15, 2023
@ti-chi-bot @LittleFall
@windtalker @yibin87
fix(expr): round decimal divide result when return type is Int512 (#7035
7883d6f 
) (#7042)

* This is an automated cherry-pick of #7035

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update divide.cpp

* Update gtest_arithmetic_functions.cpp

* Update gtest_arithmetic_functions.cpp

* Update divide.cpp

* Update gtest_arithmetic_functions.cpp

* Merge missed fixes for decimal divide

Signed-off-by: yibin <huyibin@pingcap.com>

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: yibin <huyibin@pingcap.com>
Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: yibin <huyibin@pingcap.com>
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
fix(expr): round decimal divide result when return type is Int512 (#7035
5d39778 
) (#7040)

close #7022
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
fix(expr): round decimal divide result when return type is Int512 (#7035
dd1747a 
) (#7041)

close #7022
@windtalker windtalker mentioned this pull request Mar 22, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TPCH q8 return different result when running with TiFlash and TiKV
4 participants
@LittleFall @ti-chi-bot @windtalker @gengliqi