Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expr): round decimal divide result when return type is Int512 #7035

Merged
merged 6 commits into from
Mar 10, 2023
Merged

fix(expr): round decimal divide result when return type is Int512 #7035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8410ff0
fast fix
LittleFall Mar 10, 2023
8fb5148
unit test
LittleFall Mar 10, 2023
95ec2c6
Merge branch 'master' into fix/7022
LittleFall Mar 10, 2023
07850c8
Merge branch 'master' into fix/7022
ti-chi-bot Mar 10, 2023
2a26727
Merge branch 'master' into fix/7022
ti-chi-bot Mar 10, 2023
287e41b
Merge branch 'master' into fix/7022
ti-chi-bot Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbms/src/Functions/divide.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ struct TiDBDivideFloatingImpl<A, B, false>
/// ref https://github.com/pingcap/tiflash/issues/6462
/// For division of Decimal/Decimal or Int/Decimal or Decimal/Int, we should round the result to make compatible with TiDB.
/// basically refer to https://stackoverflow.com/a/71634489
if constexpr (std::is_integral_v<Result> || std::is_same_v<Result, Int256>)
if constexpr (std::is_integral_v<Result> || std::is_same_v<Result, Int256> || std::is_same_v<Result, Int512>)
{
/// 1. do division first, get the quotient and mod, todo:(perf) find a unified `divmod` function to speed up this.
Result quotient = x / d;
Expand Down
1 change: 1 addition & 0 deletions dbms/src/Functions/tests/gtest_arithmetic_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ try
doTiDBDivideDecimalRoundInternalTest<Int64>();
doTiDBDivideDecimalRoundInternalTest<Int128>();
doTiDBDivideDecimalRoundInternalTest<Int256>();
doTiDBDivideDecimalRoundInternalTest<Int512>();
}
CATCH

Expand Down