Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run as 'syncpoint', can't use password encode by base64 #10516

Closed
knull-cn opened this issue Jan 20, 2024 · 8 comments
Closed

run as 'syncpoint', can't use password encode by base64 #10516

knull-cn opened this issue Jan 20, 2024 · 8 comments
Assignees
@asddongmen
Labels
affects-6.5 area/ticdc Issues or PRs related to TiCDC. found/gs severity/moderate type/bug The issue is confirmed as a bug.

Comments

@knull-cn
Copy link
Contributor

What did you do?

  1. set 'enable-sync-point=true'
  2. create changefeed as ' tidb -> cdc -> tidb', downstream password was encoded by base64

What did you expect to see?

create changefeed success and sync data to download stream

What did you see instead?

changefeed was occurs erros :

[CDC:ErrMySQLQueryError]fail to query session variable allow_auto_random_explicit_insert: Error 1045: Access denied for user 'cdc'@'10.2.100.15' (using password: YES)

Versions of the cluster

v6.5.0
(all versions which support syncpoint)
@knull-cn knull-cn added area/ticdc Issues or PRs related to TiCDC. type/bug The issue is confirmed as a bug. labels Jan 20, 2024
@knull-cn
Copy link
Contributor Author

knull-cn commented Jan 20, 2024 •
edited
Loading

https://github.com/pingcap/tiflow/blob/release-6.5/cdc/sink/mysql/mysql.go#L135
here is function NewMySQLSink, and call 'GetTestDB' to create mysql-connection. in this function, it will decode the password when occur error on sql.Open.
The function 'GetTestDB' definition is as follows : https://github.com/pingcap/tiflow/blob/release-6.5/pkg/sink/mysql/db_helper.go#L235-L250



the follows code is syncpoint when create mysql-connection. you can see it did not handle error generated by create mysql-connection(sql.Open):

https://github.com/pingcap/tiflow/blob/release-6.5/cdc/sink/mysql/mysql_syncpoint_store.go#L119-L132

@knull-cn
Copy link
Contributor Author

BTW:
if use base64 to encode password, the DDLSink will be created failed.
owner.newDDLSink -> owner.ddlSinkInitializer -> factory.New -> mysql.NewMySQLDDLSink -> mysql.CreateMySQLDBConn

@fubinzh
Copy link

fubinzh commented Jan 22, 2024

/severity major

@asddongmen asddongmen self-assigned this Feb 9, 2024
@asddongmen asddongmen mentioned this issue Feb 9, 2024
Closed
@asddongmen
Copy link
Contributor

cc @knull-cn @flowbehappy This issue only affects v6.5.x.

@asddongmen
Copy link
Contributor

I will fix it in the upcoming days.

@asddongmen asddongmen mentioned this issue May 22, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 29, 2024
@asddongmen
syncpoint (ticdc): make syncpoint support base64 encoded password (#1…
54e93ed 
…1162)

close #10516
hicqu added a commit to ti-chi-bot/tiflow that referenced this issue Jun 12, 2024
@hicqu
Squashed commit of the following:
a3d30ca 
commit c092599
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 12 00:26:59 2024 +0800

    pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290)

    close pingcap#11211

commit 3426e46
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 19:40:29 2024 +0800

    puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282)

    close pingcap#11219

commit 2a28078
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 16:40:37 2024 +0800

    mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261)

    close pingcap#11213

commit 2425d54
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 16:40:30 2024 +0800

    log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257)

    close pingcap#11254

commit 053cdaf
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 15:34:30 2024 +0800

    cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287)

    close pingcap#11271

commit 327ba7b
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 11:42:00 2024 +0800

    redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091)

    close pingcap#10124

commit d82ae89
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Mon Jun 10 22:28:29 2024 +0800

    ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981)

    close pingcap#10890

commit f15bec9
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Fri Jun 7 16:16:28 2024 +0800

    redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996)

    close pingcap#10900

commit ba50a0e
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 19:58:26 2024 +0800

    test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037)

    close pingcap#11015

commit 94b9897
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 17:08:56 2024 +0800

    mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946)

    close pingcap#10931

commit a912d33
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 10:49:25 2024 +0800

    mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242)

    close pingcap#11241

commit 6277d9a
Author: dongmen <20351731+asddongmen@users.noreply.github.com>
Date:   Wed May 29 20:13:22 2024 +0800

    kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184)

    close pingcap#11073

commit 54e93ed
Author: dongmen <20351731+asddongmen@users.noreply.github.com>
Date:   Wed May 29 17:43:22 2024 +0800

    syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162)

    close pingcap#10516

commit 0ba9329
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed May 29 09:07:21 2024 +0800

    (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180)

    close pingcap#11096

Signed-off-by: qupeng <qupeng@pingcap.com>
@asddongmen
Copy link
Contributor

fixed by #11162

@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jun 19, 2024
@seiya-annie
Copy link

/remove-found customer

@ti-chi-bot ti-chi-bot bot removed the report/customer Customers have encountered this bug. label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asddongmen asddongmen

Labels
affects-6.5 area/ticdc Issues or PRs related to TiCDC. found/gs severity/moderate type/bug The issue is confirmed as a bug.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kennytm @knull-cn @fubinzh @asddongmen @seiya-annie