Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure #10945

Merged
merged 2 commits into from
Apr 23, 2024
Merged

log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure #10945

merged 2 commits into from
Apr 23, 2024

Conversation

hongyunyan
Copy link
Collaborator

@hongyunyan hongyunyan commented Apr 23, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11254

What is changed and how it works?

Add more error query information to the returned error to facilitate users to know the cause of the failure.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 23, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited
Loading

Codecov Report

Merging #10945 (a0fb04f) into master (5ebadff) will increase coverage by 0.0203%.
Report is 1 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 61.6879% <50.0000%> (+0.0383%) ⬆️
dm 51.2393% <ø> (+0.0080%) ⬆️
engine 63.4020% <ø> (-0.0142%) ⬇️
Flag Coverage Δ
unit 57.3982% <50.0000%> (+0.0203%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10945        +/-   ##
================================================
+ Coverage   57.3779%   57.3982%   +0.0203%     
================================================
  Files           851        851                
  Lines        125137     125145         +8     
================================================
+ Hits          71801      71831        +30     
+ Misses        47944      47922        -22     
  Partials       5392       5392

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 03:33:00.03398519 +0000 UTC m=+58336.773888099: ☑️ agreed by CharlesCheung96.
  • 2024-04-23 08:08:38.938861723 +0000 UTC m=+74875.678764634: ☑️ agreed by lidezhu.

@ti-chi-bot ti-chi-bot bot merged commit cd065d3 into pingcap:master Apr 23, 2024
28 checks passed
@hongyunyan
Copy link
Collaborator Author

/cherry_pick release-7.1

@hongyunyan
Copy link
Collaborator Author

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@hongyunyan: new pull request created to branch release-7.1: #11255.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
@hongyunyan
Copy link
Collaborator Author

/cherry-pick release-7.5

@hongyunyan
Copy link
Collaborator Author

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jun 5, 2024
@ti-chi-bot
Copy link
Member

@hongyunyan: new pull request created to branch release-7.5: #11256.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 5, 2024
@hongyunyan @ti-chi-bot
This is an automated cherry-pick of pingcap#10945
0da4d3e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hongyunyan: new pull request created to branch release-6.5: #11257.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-6.5 from head ti-chi-bot:cherry-pick-10945-to-release-6.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-10945-to-release-6.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 5, 2024
@hongyunyan @ti-chi-bot
This is an automated cherry-pick of pingcap#10945
f795c0e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 7, 2024
@ti-chi-bot
log(ticdc): Add more error query information to the returned error to…
c5e1a9f 
… facilitate users to know the cause of the failure (#10945) (#11255)

close #11254
ti-chi-bot bot pushed a commit that referenced this pull request Jun 11, 2024
@ti-chi-bot
log(ticdc): Add more error query information to the returned error to…
2425d54 
… facilitate users to know the cause of the failure (#10945) (#11257)

close #11254
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 12, 2024
@hicqu
Squashed commit of the following:
a3d30ca 
commit c092599
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 12 00:26:59 2024 +0800

    pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290)

    close pingcap#11211

commit 3426e46
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 19:40:29 2024 +0800

    puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282)

    close pingcap#11219

commit 2a28078
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 16:40:37 2024 +0800

    mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261)

    close pingcap#11213

commit 2425d54
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 16:40:30 2024 +0800

    log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257)

    close pingcap#11254

commit 053cdaf
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 15:34:30 2024 +0800

    cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287)

    close pingcap#11271

commit 327ba7b
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 11:42:00 2024 +0800

    redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091)

    close pingcap#10124

commit d82ae89
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Mon Jun 10 22:28:29 2024 +0800

    ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981)

    close pingcap#10890

commit f15bec9
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Fri Jun 7 16:16:28 2024 +0800

    redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996)

    close pingcap#10900

commit ba50a0e
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 19:58:26 2024 +0800

    test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037)

    close pingcap#11015

commit 94b9897
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 17:08:56 2024 +0800

    mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946)

    close pingcap#10931

commit a912d33
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 10:49:25 2024 +0800

    mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242)

    close pingcap#11241

commit 6277d9a
Author: dongmen <20351731+asddongmen@users.noreply.github.com>
Date:   Wed May 29 20:13:22 2024 +0800

    kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184)

    close pingcap#11073

commit 54e93ed
Author: dongmen <20351731+asddongmen@users.noreply.github.com>
Date:   Wed May 29 17:43:22 2024 +0800

    syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162)

    close pingcap#10516

commit 0ba9329
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed May 29 09:07:21 2024 +0800

    (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180)

    close pingcap#11096

Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 13, 2024
@ti-chi-bot
log(ticdc): Add more error query information to the returned error to…
b6921c4 
… facilitate users to know the cause of the failure (#10945) (#11256)

close #11254
@hongyunyan
Copy link
Collaborator Author

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@hongyunyan: new pull request created to branch release-8.1: #11423.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jul 30, 2024
@ti-chi-bot
log(ticdc): Add more error query information to the returned error to…
7cdc3a1 
… facilitate users to know the cause of the failure (#10945) (#11423)

close #11254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@lidezhu lidezhu lidezhu approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ticdc: add the query message in the error info to help user know the problems
4 participants
@hongyunyan @ti-chi-bot @lidezhu @CharlesCheung96