-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit the maximum number of cached txns in mysql worker #10896
Labels
affects-6.5
affects-7.1
affects-7.5
affects-8.1
area/ticdc
Issues or PRs related to TiCDC.
component/sink
Sink component.
severity/moderate
type/enhancement
The issue or PR belongs to an enhancement.
Comments
CharlesCheung96
added
type/feature
Issues about a new feature
component/sink
Sink component.
type/enhancement
The issue or PR belongs to an enhancement.
area/ticdc
Issues or PRs related to TiCDC.
and removed
type/feature
Issues about a new feature
labels
Apr 10, 2024
This was referenced Apr 18, 2024
CharlesCheung96
added
type/bug
The issue is confirmed as a bug.
and removed
type/enhancement
The issue or PR belongs to an enhancement.
labels
Apr 18, 2024
This was referenced Apr 22, 2024
This was referenced Apr 24, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
This was referenced Apr 26, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 26, 2024
flowbehappy
added
type/enhancement
The issue or PR belongs to an enhancement.
and removed
type/bug
The issue is confirmed as a bug.
labels
Apr 29, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 29, 2024
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this issue
Apr 29, 2024
This was referenced Jun 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
affects-7.1
affects-7.5
affects-8.1
area/ticdc
Issues or PRs related to TiCDC.
component/sink
Sink component.
severity/moderate
type/enhancement
The issue or PR belongs to an enhancement.
Is your feature request related to a problem?
ref sink to mysql (cdc) workload skew issue
PR #10376 tries to fix the skew problem by sending a transaction to a random worker after the depended transactions are executed. For conflicting transactions, only one transaction can be executed among all workers at a time, which can also be called serial execution or one by one. During synchronous real-time streaming, conflicting transactions are executed serially in the upstream cluster, so it is a reasonable choice for TiCDC to execute these transactions serially.
However, for other common scenarios, this approach can be problematic:
New Proposal
It is better to use a compromise optimization that replaces
one by one
withbatch by batch
:The batch mechanism can effectively improve the throughput of a single worker, so it is necessary to preserve the fast dependencies resolving optimization in
conflict detector
.At the same time, to avoid workload skew problems, we could limit the maximum number of cached txns in single worker. When the limit is exceeded, the conflict detector should wait for all transactions cached in the worker to complete before sending a new event to it.
The text was updated successfully, but these errors were encountered: