Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): Revert changes related to the conflict detector (#10897) #10986

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10897

What problem does this PR solve?

Issue Number: ref #10896

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 88.65979% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@5e1b22e). Click here to learn what that means.

Additional details and impacted files
Components Coverage Δ
cdc 61.7379% <0.0000%> (?)
dm 51.2697% <0.0000%> (?)
engine 63.3526% <0.0000%> (?)
Flag Coverage Δ
unit 57.4262% <88.6597%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #10986   +/-   ##
================================================
  Coverage               ?   57.4262%           
================================================
  Files                  ?        849           
  Lines                  ?     125070           
  Branches               ?          0           
================================================
  Hits                   ?      71823           
  Misses                 ?      47855           
  Partials               ?       5392           

Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test d45047c link true /test dm-integration-test
pull-cdc-integration-kafka-test d45047c link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CharlesCheung96
Copy link
Contributor

Batch cherry-pick in #10958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants