Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

row changed event physical table id is spread over the code base #11194

Closed
3AceShowHand opened this issue May 29, 2024 · 0 comments · Fixed by #11195
Closed

row changed event physical table id is spread over the code base #11194

3AceShowHand opened this issue May 29, 2024 · 0 comments · Fixed by #11195
Assignees
@3AceShowHand
Labels
area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.

Comments

@3AceShowHand
Copy link
Contributor

physical table id is the table id stored in the key part.

  • for the non-partitioned table, it's the same as the table id.
  • for the partitioned table, it's the real table id.

We should use physical table as the event's table id
@3AceShowHand 3AceShowHand self-assigned this May 29, 2024
@3AceShowHand 3AceShowHand added type/enhancement The issue or PR belongs to an enhancement. area/ticdc Issues or PRs related to TiCDC. labels May 29, 2024
@3AceShowHand 3AceShowHand mentioned this issue May 29, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 30, 2024
@3AceShowHand
model(ticdc): add one method to get the row changed event correspondi…
dce7d23 
…ng table id (#11195)

close #11194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3AceShowHand 3AceShowHand

Labels
area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

model(ticdc): add one method to get the row changed event corresponding table id 3AceShowHand/tiflow
1 participant
@3AceShowHand