Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model(ticdc): add one method to get the row changed event corresponding table id #11195

Merged
merged 3 commits into from
May 30, 2024

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11194

What is changed and how it works?

  • add one method GetTableID() int64 to the RowChangedEvent struct

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 29, 2024
Copy link
Contributor

ti-chi-bot bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
Copy link
Contributor

ti-chi-bot bot commented May 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-29 10:49:29.813203137 +0000 UTC m=+2859923.570338705: ☑️ agreed by CharlesCheung96.
  • 2024-05-29 10:53:17.419773483 +0000 UTC m=+2860151.176909051: ☑️ agreed by asddongmen.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.6033%. Comparing base (40df850) to head (3041c22).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.4037% <58.8235%> (-0.0364%) ⬇️
dm 51.1840% <ø> (-0.0121%) ⬇️
engine 63.4091% <ø> (ø)
Flag Coverage Δ
unit 57.6033% <58.8235%> (-0.0227%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11195        +/-   ##
================================================
- Coverage   57.6260%   57.6033%   -0.0227%     
================================================
  Files           849        849                
  Lines        125957     125958         +1     
================================================
- Hits          72584      72556        -28     
- Misses        47979      48004        +25     
- Partials       5394       5398         +4     

@ti-chi-bot ti-chi-bot bot merged commit dce7d23 into pingcap:master May 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

row changed event physical table id is spread over the code base
3 participants