Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ticdc,dm): download_binaries failed when branch is not valid. #11563

Closed
wk989898 opened this issue Sep 3, 2024 · 1 comment · Fixed by #11564
Closed

test(ticdc,dm): download_binaries failed when branch is not valid. #11563

wk989898 opened this issue Sep 3, 2024 · 1 comment · Fixed by #11564
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. severity/major type/bug The issue is confirmed as a bug.

Comments

@wk989898
Copy link
Collaborator

wk989898 commented Sep 3, 2024

What did you do?

run script dm/tests/download-integration-test-binaries.sh branch and scripts/download-integration-test-binaries.sh

What did you expect to see?

download binaries successfully

What did you see instead?

download binaries failed

Versions of the cluster

master
@wk989898 wk989898 added area/ticdc Issues or PRs related to TiCDC. type/bug The issue is confirmed as a bug. labels Sep 3, 2024
@wk989898
Copy link
Collaborator Author

wk989898 commented Sep 3, 2024 •
edited
Loading

It makes CI fail when creating a pull request to a new branch. When testing on a newly created branch, other binaries of the same branch as the repository are automatically downloaded, which will cause the test to fail due to the different branch names of each repository.
Affected PR: #11538

@wk989898 wk989898 mentioned this issue Sep 3, 2024
Merged
@jebter jebter added component/test Unit tests and integration tests component. severity/major labels Sep 4, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 6fc5a49 Sep 5, 2024
wk989898 added a commit to wk989898/tiflow that referenced this issue Sep 6, 2024
@wk989898
test(ticdc,dm): modify download-integration-test-binaries script (pin…
4a5d301 
…gcap#11564)

close pingcap#11563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(ticdc,dm): modify download-integration-test-binaries script wk989898/tiflow
3 participants
@jebter @wk989898 @CharlesCheung96