Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: Support Vector data type | tidb=master pd=master tikv=master #11538

Merged
merged 39 commits into from
Sep 23, 2024

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Aug 29, 2024

What problem does this PR solve?

Issue Number: ref #11530

What is changed and how it works?

Detect TypeTiDBVectorFloat32, and convert vector to string in DML sink.

CREATE table test.simple(id int primary key, data VECTOR(5));
INSERT INTO test.simple(id, data) VALUES (1, '[1,2,3,4,5]');

Some changes like converting VECTOR to LONGTEXT on an unsupported downstream, supporting multiple output protocols may be temporary. Converting VECTOR to LONGTEXT is automatical when downstream is not TiDB or TiDB version less than 8.3.0.

CREATE table test.simple(id int primary key, data LONGTEXT);
INSERT INTO test.simple(id, data) VALUES (1, '[1,2,3,4,5]');

Check List

Tests

A total of 1 tables need to be compared

Comparing the table structure of `test`.`sample` ... equivalent
Comparing the table data of `test`.`sample` ... equivalent
_____________________________________________________________________________
Progress [============================================================>] 100% 0/0
A total of 1 table have been compared and all are equal.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

yes

Release note

support vector data type

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2024

Hi @wk989898. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 29, 2024
@3AceShowHand
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 29, 2024
@wk989898
Copy link
Collaborator Author

/area ticdc

@ti-chi-bot ti-chi-bot bot added the area/ticdc Issues or PRs related to TiCDC. label Sep 14, 2024
@3AceShowHand
Copy link
Contributor

3AceShowHand commented Sep 20, 2024

why this is merged to pingcap:feature/vector-data-type, instead of the master branch ?

return n, true
}

func formatQuery(sql string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only rewrite the DDL ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the vector format is similar to string in DML.

@wk989898
Copy link
Collaborator Author

why this is merged to pingcap:feature/vector-data-type, instead of the master branch ?

To keep the code tidy. Vector index support will also be provided in the future.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024
@wk989898
Copy link
Collaborator Author

/retest

2 similar comments
@wk989898
Copy link
Collaborator Author

/retest

@wk989898
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 06:28:08.28334901 +0000 UTC m=+1201758.023772949: ☑️ agreed by 3AceShowHand.
  • 2024-09-23 09:35:12.848310763 +0000 UTC m=+1472182.588734701: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit d9f0a53 into pingcap:feature/vector-data-type Sep 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. area/ticdc Issues or PRs related to TiCDC. contribution This PR is from a community contributor. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants