-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ticdc: Support Vector data type | tidb=master pd=master tikv=master #11538
ticdc: Support Vector data type | tidb=master pd=master tikv=master #11538
Conversation
Hi @wk989898. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/area ticdc |
why this is merged to pingcap:feature/vector-data-type, instead of the master branch ? |
return n, true | ||
} | ||
|
||
func formatQuery(sql string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only rewrite the DDL ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the vector format is similar to string in DML.
To keep the code tidy. Vector index support will also be provided in the future. |
/retest |
2 similar comments
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
d9f0a53
into
pingcap:feature/vector-data-type
What problem does this PR solve?
Issue Number: ref #11530
What is changed and how it works?
Detect TypeTiDBVectorFloat32, and convert vector to string in DML sink.
Some changes like converting VECTOR to LONGTEXT on an unsupported downstream, supporting multiple output protocols may be temporary. Converting VECTOR to LONGTEXT is automatical when downstream is not TiDB or TiDB version less than 8.3.0.
Check List
Tests
a. start tidb cluster
b. create a changefeed
c. load vector data with https://github.com/breezewish/tidb-vector-bench
d. check data consistency with sync_diff_inspector
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
yes
Release note