Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiCDC keeps warning on removed changefeeds #2156

Closed
lichunzhu opened this issue Jun 24, 2021 · 5 comments · Fixed by #3021
Closed

TiCDC keeps warning on removed changefeeds #2156

lichunzhu opened this issue Jun 24, 2021 · 5 comments · Fixed by #3021
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@lichunzhu
Copy link
Contributor

lichunzhu commented Jun 24, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
    Set up TiCDC, start a changefeed, and then remove it forcely.

  2. What did you expect to see?
    Prometheus alerts won't be triggered any more.

  3. What did you see instead?
    cdc_checkpoint_high_delay
    cdc_processor_checkpoint_tso_no_change_for_1m
    cdc_resolvedts_high_delay
    tikv_cdc_min_resolved_ts_no_change_for_1m
    still alerts.

  4. Versions of the cluster

    • Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      (paste TiDB cluster version here)
      
    • TiCDC version (execute cdc version):

      (paste TiCDC version here)
      

      v5.0.1,v4.0.12

@lichunzhu lichunzhu added the type/bug The issue is confirmed as a bug. label Jun 24, 2021
@lichunzhu
Copy link
Contributor Author

Although prometheus metrics is deleted, we should also adjust alert rules.

@lichunzhu
Copy link
Contributor Author

lichunzhu commented Jun 25, 2021

more details: this changefeed is already deleted forcely.
image
image

@amyangfei
Copy link
Contributor

amyangfei commented Jun 26, 2021

I have checked in a test environment,

  • where I created two changedfeeds, naming bypass-cf-1 and bypass-cf-2

  • after running some time, I removed the changefeed bypass-cf-2

  • It is to observe that metrics of bypass-cf-2 stop updating, as follows

Screen Shot 2021-06-26 at 23 07 59

  • The given alert doesn't fire in prometheus, for example, the expr for alert item changes(ticdc_processor_checkpoint_ts[1m]) is expr:changes(ticdc_processor_checkpoint_ts[1m]) < 1, we can check the expression in prometheus and only metric from bypass-cf-1 is available

Screen Shot 2021-06-26 at 23 10 20

To summarize, the given bug can't be reproduced, and maybe there exists an active changefeed that is not replicating normally in the user's scenario.

@amyangfei
Copy link
Contributor

Closed by #2177 and #23133

@3pointer 3pointer reopened this Sep 15, 2021
@3pointer
Copy link
Contributor

tikv should handle tikv_cdc_min_resolved_ts_no_change_for_1m alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants