Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner/processor: delete metric when changefeed or processor stops #2177

Merged
merged 10 commits into from
Jul 17, 2021
Merged

owner/processor: delete metric when changefeed or processor stops #2177

merged 10 commits into from
Jul 17, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Fix #2156

What is changed and how it works?

  • Delete metric when changefeed or processor stops
  • Master new owner/processor does not have this bug, keep the same behavior as master branch.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Cleanup changefeed metrics when changefeed is removed.
  • Cleanup processor metrics when processor exits.

@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jun 28, 2021
@amyangfei amyangfei added this to the v5.0.4 milestone Jun 28, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Jun 29, 2021
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@5c29a5d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #2177   +/-   ##
================================================
  Coverage               ?   54.8070%           
================================================
  Files                  ?        166           
  Lines                  ?      19950           
  Branches               ?          0           
================================================
  Hits                   ?      10934           
  Misses                 ?       7946           
  Partials               ?       1070

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 6, 2021
overvenus
overvenus approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2021
@amyangfei amyangfei added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 16, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1129bd3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2021
@amyangfei
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 70124d4 into pingcap:release-5.0 Jul 17, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2313.

ti-chi-bot added a commit that referenced this pull request Jul 18, 2021
@ti-chi-bot
owner/processor: delete metric when changefeed or processor stops (#2177
071480b 
) (#2313)
@amyangfei amyangfei deleted the clean-changefeed-metric branch July 19, 2021 03:19
@amyangfei amyangfei mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @codecov-commenter @ti-chi-bot @overvenus @lonng