Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner/processor: delete metric when changefeed or processor stops (#2177) #2313

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2177

What problem does this PR solve?

Fix #2156

What is changed and how it works?

  • Delete metric when changefeed or processor stops
  • Master new owner/processor does not have this bug, keep the same behavior as master branch.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Cleanup changefeed metrics when changefeed is removed.
  • Cleanup processor metrics when processor exits.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 17, 2021
@amyangfei amyangfei added this to the v5.0.4 milestone Jul 17, 2021
@amyangfei
Copy link
Contributor

/merge

@amyangfei amyangfei removed the type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. label Jul 17, 2021
@amyangfei amyangfei modified the milestones: v5.0.4, v4.0.15 Jul 17, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2313 (268a2e4) into release-4.0 (5a78519) will decrease coverage by 0.3306%.
The diff coverage is 25.0000%.

@@                 Coverage Diff                 @@
##           release-4.0      #2313        +/-   ##
===================================================
- Coverage      54.8080%   54.4774%   -0.3307%     
===================================================
  Files              166        166                
  Lines            19904      19911         +7     
===================================================
- Hits             10909      10847        -62     
- Misses            7938       8028        +90     
+ Partials          1057       1036        -21     

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 28e34db

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 071480b into pingcap:release-4.0 Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants