Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the content of the configure file when executing the query command by cli #8824

Closed
nongfushanquan opened this issue Apr 20, 2023 · 7 comments · Fixed by #8836
Closed
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@nongfushanquan
Copy link
Contributor

What did you do?

When the user executes the query command with CLI, some irrelevant information remains.

What did you expect to see?

only useful information will be showed.

What did you see instead?

as title described

Versions of the cluster

6.1 & 6.5

@nongfushanquan nongfushanquan added area/ticdc Issues or PRs related to TiCDC. type/bug The issue is confirmed as a bug. labels Apr 20, 2023
@nongfushanquan
Copy link
Contributor Author

/assign @charleszheng44

@charleszheng44
Copy link
Contributor

A sample output

$ tiup cdc cli changefeed query --pd=http://127.0.0.1:2379 --changefeed-id="simple-replication-task"
tiup is checking updates for component cdc ...
Starting component `cdc`: /home/zc/.tiup/components/cdc/v7.0.0/cdc cli changefeed query --pd=http://127.0.0.1:2379 --changefeed-id=simple-replication-task
{
  "upstream_id": 7224324985659958554,
  "namespace": "default",
  "id": "simple-replication-task",
  "sink_uri": "kafka://127.0.0.1:9092/quickstart-events?protocol=canal-json",
  "config": {
    "memory_quota": 1073741824,
    "case_sensitive": true,
    "enable_old_value": true,
    "force_replicate": false,
    "ignore_ineligible_table": false,
    "check_gc_safe_point": true,
    "enable_sync_point": false,
    "bdr_mode": false,
    "sync_point_interval": 600000000000,
    "sync_point_retention": 86400000000000,
    "filter": {
      "rules": [
        "*.*"
      ],
      "event_filters": null
    },
    "mounter": {
      "worker_num": 16
    },
    "sink": {
      "protocol": "canal-json",
      "schema_registry": "",
      "csv": {
        "delimiter": ",",
        "quote": "\"",
        "null": "\\N",
        "include_commit_ts": false
      },
      "column_selectors": null,
      "transaction_atomicity": "",
      "encoder_concurrency": 16,
      "terminator": "\r\n",
      "date_separator": "none",
      "enable_partition_separator": false
    },
    "consistent": {
      "level": "none",
      "max_log_size": 64,
      "flush_interval": 2000,
      "storage": "",
      "use_file_backend": false
    },
    "scheduler": {
      "enable_table_across_nodes": false,
      "region_threshold": 100000,
      "write_key_threshold": 0
    }
  },
  "create_time": "2023-04-20 19:33:10.147",
  "start_ts": 440937844585529346,
  "resolved_ts": 440937850877247491,
  "target_ts": 0,
  "checkpoint_tso": 440937850877247491,
  "checkpoint_time": "2023-04-20 19:33:34.052",
  "state": "normal",
  "error": null,
  "error_history": null,
  "creator_version": "v7.0.0",
  "task_status": [
    {
      "capture_id": "8ea42ceb-5f52-4e9c-b943-b14eca0164e8",
      "table_ids": [],
      "table_operations": null
    }
  ]
}

@fubinzh
Copy link

fubinzh commented Apr 21, 2023

/severity moderate

@nongfushanquan
Copy link
Contributor Author

Because some variables are mutually exclusive and appear in the configuration file, so it appears to be very messy.
such as if there is "protocol": "canal-json", the variables "schema_registry" and "csv" should not appear

@nongfushanquan
Copy link
Contributor Author

/remove-label affects-6.5

@ti-chi-bot ti-chi-bot bot removed the affects-6.5 label May 30, 2023
@nongfushanquan
Copy link
Contributor Author

/remove-label affects-6.1

@ti-chi-bot ti-chi-bot bot removed the affects-6.1 label May 30, 2023
@nongfushanquan
Copy link
Contributor Author

/remove-label affects-7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants