Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/config(ticdc): hide fields that are not required for specific protocols (#8836) #9064

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8836

What problem does this PR solve?

Issue Number: close #8824

What is changed and how it works?

Hide fields that are not required for specific protocols and downstream types. Since we utilize a common changefeed configuration template, certain fields may not be utilized for certain protocols.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Execute a manual test on a TiDB cluster generated with TiUP playground, and include a partial output of the cdc cli changefeed query command. The output has been modified to exclude any unnecessary fields, such as csv and schema_registry, as well as other fields that are not utilized.
{
  "upstream_id": 7225670347271394026,
  "namespace": "default",
  "id": "simple-replication-task",
  "sink_uri": "kafka://127.0.0.1:9092/quickstart-events?protocol=canal-json",
  "config": {
    "memory_quota": 1073741824,
    "case_sensitive": true,
    "enable_old_value": true,
    "force_replicate": false,
    "ignore_ineligible_table": false,
    "check_gc_safe_point": true,
    "enable_sync_point": false,
    "bdr_mode": false,
    "sync_point_interval": 600000000000,
    "sync_point_retention": 86400000000000,
    "filter": {
      "rules": [
        "*.*"
      ],
      "event_filters": null
    },
    "mounter": {
      "worker_num": 16
    },
    "sink": {
      "protocol": "canal-json",
      "transaction_atomicity": "",
      "encoder_concurrency": 16,
      "terminator": "\r\n",
      "date_separator": "none",
      "enable_partition_separator": true,
      "enable_kafka_sink_v2": false,
      "only_output_updated_columns": false
    },
    "consistent": {
      "level": "none",
      "max_log_size": 64,
      "flush_interval": 2000,
      "storage": "",
      "use_file_backend": false
    },
    "scheduler": {
      "enable_table_across_nodes": false,
      "region_threshold": 100000,
      "write_key_threshold": 0
    },
    "integrity": {
      "integrity_check_level": "none",
      "corruption_handle_level": "warn"
    }
  },
  "create_time": "2023-04-24 10:33:13.965",
  "start_ts": 441019949069107204,
  "resolved_ts": 441019961560268803,
  "target_ts": 0,
  "checkpoint_tso": 441019961560268803,
  "checkpoint_time": "2023-04-24 10:34:01.450",
  "state": "normal",
  "creator_version": "v7.1.0-master-dirty",
  "task_status": [
    {
      "capture_id": "90d43a75-9047-4b3f-a7ab-37e6a3bff357",
      "table_ids": [],
      "table_operations": null
    }
  ]
}

Questions

N/A

Will it cause performance regression or break compatibility?

N/A

Do you need to update user documentation, design documentation or monitoring documentation?

N/A

Release note

`None`

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 26, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 26, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels May 26, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 26, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 26, 2023

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 3b5185c link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CharlesCheung96
Copy link
Contributor

/hold dateSeperate should be set to day

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 30, 2023
@charleszheng44
Copy link
Contributor

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@charleszheng44 you're already a collaborator in repo ti-chi-bot/tiflow

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nongfushanquan
Copy link
Contributor

/close

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

@nongfushanquan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants