-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/config(ticdc): hide fields that are not required for specific protocols (#8836) #9064
pkg/config(ticdc): hide fields that are not required for specific protocols (#8836) #9064
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold dateSeperate should be set to day |
/cherry-pick-invite |
@charleszheng44 you're already a collaborator in repo |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@nongfushanquan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #8836
What problem does this PR solve?
Issue Number: close #8824
What is changed and how it works?
Hide fields that are not required for specific protocols and downstream types. Since we utilize a common changefeed configuration template, certain fields may not be utilized for certain protocols.
Check List
Tests
Execute a manual test on a TiDB cluster generated with TiUP playground, and include a partial output of the
cdc cli changefeed query
command. The output has been modified to exclude any unnecessary fields, such ascsv
andschema_registry
, as well as other fields that are not utilized.Questions
N/A
Will it cause performance regression or break compatibility?
N/A
Do you need to update user documentation, design documentation or monitoring documentation?
N/A
Release note