owner: fix multiple owners exist when owner campaign key is deleted #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
type/bugfix
|
/run-all-tests |
|
/run-all-tests |
|
/run-kafka-tests |
overvenus
reviewed
Nov 13, 2020
| return cerror.ErrOwnerCampaignKeyDeleted.GenWithStackByArgs() | ||
| } | ||
| restart: | ||
| wch := o.etcdClient.Client.Watch(ctx, key, clientv3.WithRev(resp.Header.Revision+1)) |
There was a problem hiding this comment.
The change with revision resp.Header.Revision is not needed, so +1
zier-one
approved these changes
Nov 19, 2020
|
LGTM |
ti-srebot
approved these changes
Nov 19, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/run-kafka-tests |
amyangfei
commented
Nov 19, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/run-all-tests |
|
/run-integration-tests |
|
@amyangfei merge failed. |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Nov 19, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix https://github.com/pingcap/ticdc/issues/1044
In some cases, if the campaign owner key is deleted, the owner itself doesn't aware of it and continues running the owner routines. While at the same time, another capture will campaign to be the new owner. In this scenario, multiple owners could exist.
What is changed and how it works?
Add a background campaign key watcher in the owner background.
Check List
Tests
Release note