owner: fix multiple owners exist when owner campaign key is deleted (#1072) #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
type/bugfix
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1104 +/- ##
================================================
Coverage ? 36.5817%
================================================
Files ? 109
Lines ? 11380
Branches ? 0
================================================
Hits ? 4163
Misses ? 6793
Partials ? 424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1072 to release-4.0
What problem does this PR solve?
Fix https://github.com/pingcap/ticdc/issues/1044
In some cases, if the campaign owner key is deleted, the owner itself doesn't aware of it and continues running the owner routines. While at the same time, another capture will campaign to be the new owner. In this scenario, multiple owners could exist.
What is changed and how it works?
Add a background campaign key watcher in the owner background.
Check List
Tests
Release note