Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc(ticdc): fix data race in gc manager #10846

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Mar 25, 2024

What problem does this PR solve?

Issue Number: close #10688
fix data race

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2024
@sdojjy sdojjy self-assigned this Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #10846 (cc1804e) into master (99b3eb4) will increase coverage by 3.6334%.
Report is 9 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 61.9096% <100.0000%> (∅)
dm 51.2131% <ø> (-0.0061%) ⬇️
engine 63.3879% <ø> (+0.0155%) ⬆️
Flag Coverage Δ
unit 57.5553% <100.0000%> (+3.6334%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10846        +/-   ##
================================================
+ Coverage   53.9219%   57.5553%   +3.6334%     
================================================
  Files           403        853       +450     
  Lines         63655     126937     +63282     
================================================
+ Hits          34324      73059     +38735     
- Misses        26627      48440     +21813     
- Partials       2704       5438      +2734     

@sdojjy
Copy link
Member Author

sdojjy commented Mar 26, 2024

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Mar 26, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-26 02:32:04.203447416 +0000 UTC m=+1948751.225693805: ☑️ agreed by asddongmen.
  • 2024-03-26 02:33:54.475611872 +0000 UTC m=+1948861.497858260: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot merged commit 71c61af into pingcap:master Mar 26, 2024
27 of 28 checks passed
@sdojjy sdojjy deleted the fix-data-race-in-gc-manager branch March 26, 2024 03:00
@3AceShowHand
Copy link
Contributor

This is cherry-pick back to release-7.5 by the PR #10646

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-7.5 from head ti-chi-bot:cherry-pick-10846-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.5 and ti-chi-bot:cherry-pick-10846-to-release-7.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race found in the gc manager
4 participants