Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): calculate row level checksum for timestmap by using UTC time zone (#10564) #10646

Merged
merged 33 commits into from
Apr 28, 2024
Merged

mounter(ticdc): calculate row level checksum for timestmap by using UTC time zone (#10564) #10646

merged 33 commits into from
Apr 28, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 26, 2024 •
edited by 3AceShowHand
Loading

This is an automated cherry-pick of #10564

What problem does this PR solve?

Issue Number: close #10573

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

fix e2e checksum on the timestamp value failed since does not consider time zone

@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#10564
3e52aee 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 26, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 26, 2024
Merged
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024
@asddongmen asddongmen mentioned this pull request Apr 16, 2024
Merged
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 16, 2024
@3AceShowHand
Copy link
Contributor

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand 3AceShowHand mentioned this pull request Apr 23, 2024
Merged
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/test dm-integration-test

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand 3AceShowHand force-pushed the cherry-pick-10564-to-release-7.5 branch from 7595ea9 to 8168a51 Compare April 25, 2024 03:42
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3AceShowHand
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 47417d7 into pingcap:release-7.5 Apr 28, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees

@3AceShowHand 3AceShowHand

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @3AceShowHand @asddongmen @hicqu @sdojjy