Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* (ticdc): manually cherry-pick simple protocol to release-7.5 #10898

Merged
merged 19 commits into from
Apr 28, 2024
Merged

* (ticdc): manually cherry-pick simple protocol to release-7.5 #10898

merged 19 commits into from
Apr 28, 2024

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Apr 10, 2024 •
edited
Loading

Signed-off-by: dongmen 414110582@qq.com

What problem does this PR solve?

Issue Number: close #10874

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Manually cherry-pick simple protocol function to release-7.5

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 10, 2024
@asddongmen asddongmen marked this pull request as draft April 10, 2024 07:55
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@asddongmen
config (ticdc): add simple protol related coonfiguration
abe7f57 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
codec (ticdc): add bootstrap function
1fc16e2 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
codec (ticdc): cherry pick TestConfig4Simple
295b243 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
tests (ticdc): cherry pick simple protocol integration test cases
4648c5a 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
tests (ticdc): fix simple protorol integration tests
cee9827 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

@asddongmen
tests (ticdc): fix kafka big message integration tests
dfa5c1a 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
Copy link
Contributor Author

pull-cdc-integration-kafka-test

@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

1 similar comment
@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 15, 2024

@asddongmen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-pulsar-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run all jobs.

In response to this:

/test cdc-integration-kafka-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 15, 2024
Closed
Closed
@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

@asddongmen asddongmen self-assigned this Apr 16, 2024
@asddongmen
Copy link
Contributor Author

/test cdc-integration-mysql-test

@asddongmen
Copy link
Contributor Author

Block by #10646

@wuhuizuo
Copy link
Contributor

/review summary the changes

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2024

@wuhuizuo:
I Skip it since the diff size(423310 bytes > 80000 bytes) is too large

In response to this:

/review summary the changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2024
@asddongmen
merge upstream/release-7.5
d18fb35 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
resolve conflict
62f846e 
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2024
@asddongmen
simple (ticdc): fix failedling unit tetest cases
5e49a0e 
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 28, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 28, 2024
@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

@hongyunyan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 28, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 07:12:24.046968788 +0000 UTC m=+168497.804104362: ☑️ agreed by 3AceShowHand.
  • 2024-04-28 08:06:39.946724916 +0000 UTC m=+171753.703860489: ☑️ agreed by CharlesCheung96.

@asddongmen
config (ticdc): fix failing test
ff1a1ef 
Signed-off-by: dongmen <414110582@qq.com>
@asddongmen
Copy link
Contributor Author

/retest

2 similar comments
@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit fd3a6e7 into pingcap:release-7.5 Apr 28, 2024
13 checks passed
@asddongmen asddongmen deleted the simple-protocol-cherry-pick branch April 30, 2024 03:46
@asddongmen asddongmen mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees

@asddongmen asddongmen

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@asddongmen @wuhuizuo @3AceShowHand @hongyunyan @CharlesCheung96 @ti-chi-bot