Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: turn on the tidb_enable_change_multi_schema switch in some tests (#1194) #1195

Merged
merged 4 commits into from
Dec 22, 2020
Merged

tests: turn on the tidb_enable_change_multi_schema switch in some tests (#1194) #1195

merged 4 commits into from
Dec 22, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1194 to release-4.0

What problem does this PR solve?

pingcap/tidb#21533 disables multi schema change feature by default, which leads to some tests failure caused by ERROR 8200 (HY000) at line 12: Unsupported multi schema change

What is changed and how it works?

Turn on the tidb_enable_change_multi_schema switch in tests where multi schema change happens

Note cherry-pick just wants to keep the test code same as far as possible

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei @ti-srebot
cherry pick pingcap#1194 to release-4.0
4e4b467 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 11, 2020
Merged
@ti-srebot ti-srebot added status/ptal Could you please take a look? component/test Unit tests and integration tests component. type/4.0-cherry-pick labels Dec 11, 2020
@ti-srebot ti-srebot added this to the v4.0.10 milestone Dec 11, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2020
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1184

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199
  • 1199

@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1199
  • 1199

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-4.0@c0654e3). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-4.0      #1195   +/-   ##
================================================
  Coverage               ?   45.8177%           
================================================
  Files                  ?        112           
  Lines                  ?      11740           
  Branches               ?          0           
================================================
  Hits                   ?       5379           
  Misses                 ?       5756           
  Partials               ?        605

@ti-srebot ti-srebot merged commit 83eb99e into pingcap:release-4.0 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

Assignees

@amyangfei amyangfei

Labels
component/test Unit tests and integration tests component. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look?
Projects
None yet
Milestone
v4.0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @amyangfei @codecov-io