Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the output in changefeed out of order #1247

Merged
merged 53 commits into from
Jan 21, 2021

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Dec 29, 2020

What problem does this PR solve?

fix the output in changefeed out of order

What is changed and how it works?

add a middleware between sorter and sink, make the life cycle of sink managed by processor.

before this pr:
image

after this pr:
image

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix the output in changefeed out of order

@zier-one
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jan 6, 2021

/run-integration-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jan 6, 2021

/run-integration-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jan 6, 2021

/run-integration-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jan 6, 2021

/run-integration-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@leoppro merge failed.

@zier-one
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@leoppro merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@leoppro merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@leoppro merge failed.

@amyangfei
Copy link
Contributor

/run-kafka-tests

1 similar comment
@zier-one
Copy link
Contributor Author

/run-kafka-tests

@zier-one
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 5c62e67 into pingcap:master Jan 21, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Jan 21, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants