sink: fix the memory leak in sink manager #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please label your PR and follow PR title style, thanks! https://github.com/pingcap/community/blob/master/contributors/commit-message-pr-style.md |
ti-srebot
pushed a commit
that referenced
this pull request
Feb 3, 2021
zier-one
changed the title
zier-one
added
type/bugfix
|
LGTM |
ti-srebot
approved these changes
Feb 4, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix the memory leak in sink manager, this bug is import by #1247
What is changed and how it works?
https://github.com/pingcap/ticdc/blob/6febbae2ec0425fcad6ad74a0644ec595ccc0189/cdc/sink/manager.go#L149
t.buffert.bufferRowChangeEvnetThe yellow squares is unreachable but can't be GC, because the
b.bufferreference thearrayand thearrayinclude the yellow squares, the GO GC can't reclaim this space.Check List
Tests
Release note