-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch (ticdc): add etcdTxnMaxOps to limit the ops number of an etcd txn #3681
batch (ticdc): add etcdTxnMaxOps to limit the ops number of an etcd txn #3681
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which versions are affected by this issue? |
no any for now |
/run-integration-tests |
/run-integration-tests |
1 similar comment
/run-integration-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8610e1f
|
/run-dm-integration-tests |
This PR needs to cherrypick to release 5.3, 5.2, 5.1, 5.0, 4.0 branch. |
…xn (pingcap#3681) (cherry picked from commit 6f70625)
…xn (pingcap#3681) (cherry picked from commit 6f70625)
…xn (pingcap#3681) (cherry picked from commit 6f70625)
…xn (pingcap#3681) (cherry picked from commit 6f70625)
What problem does this PR solve?
Since #3227 batch multiple changefeed patches into a batch and submit them as an etcd transaction, if there many changefeeds in the cdc cluster, it may cause a
"etcdserver: too many operations in txn request\
error.What is changed and how it works?
add
etcdTxnMaxOps
to limit the ops number of an etcd txnCheck List
Tests
Code changes
Side effects
Related changes
Release note