Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv(ticdc): reduce eventfeed rate limited log (#4072) #4113

Merged
merged 5 commits into from
Jan 18, 2022
Merged

kv(ticdc): reduce eventfeed rate limited log (#4072) #4113

merged 5 commits into from
Jan 18, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4072

What is changed and how it works?

Issue Number: close #4006

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note 

Reduce "EventFeed retry rate limited" logs

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Dec 28, 2021
@overvenus overvenus force-pushed the cherry-pick-4072-to-release-5.0 branch from c6d46a6 to 65e4144 Compare December 28, 2021 15:59
@overvenus
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@39ebddf). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #4113   +/-   ##
================================================
  Coverage               ?   64.1956%           
================================================
  Files                  ?        160           
  Lines                  ?      16741           
  Branches               ?          0           
================================================
  Hits                   ?      10747           
  Misses                 ?       5052           
  Partials               ?        942

@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 30, 2021
@overvenus overvenus added this to the v5.0.7 milestone Jan 11, 2022
@overvenus
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 65e4144

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022
@overvenus
Copy link
Member

/run-leak-test

1 similar comment
@overvenus
Copy link
Member

/run-leak-test

@overvenus
Copy link
Member

/run-leak-test

@ti-chi-bot ti-chi-bot merged commit 64189ca into pingcap:release-5.0 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@overvenus overvenus

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @overvenus @codecov-commenter @VelocityLight