Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM *(ticdc): cli support cdc cluster #5412

Merged
merged 46 commits into from
May 19, 2022

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented May 12, 2022

What problem does this PR solve?

Issue Number: ref #5301

What is changed and how it works?

cdc command support new flag : cluster-id, which identity the cdc cluster id
the default value is "default"

Check List

Tests

  • Unit test
  • Integration test

Release note

`None`.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #5412 (c7332b8) into master (7a80b61) will decrease coverage by 0.0625%.
The diff coverage is 55.1312%.

Flag Coverage Δ
cdc 60.8578% <54.0845%> (-0.1064%) ⬇️
dm 51.9395% <60.9375%> (-0.0208%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5412        +/-   ##
================================================
- Coverage   55.9233%   55.8608%   -0.0626%     
================================================
  Files           528        529         +1     
  Lines         69935      69888        -47     
================================================
- Hits          39110      39040        -70     
- Misses        27100      27119        +19     
- Partials       3725       3729         +4     

sdojjy added 4 commits May 13, 2022 16:55
# Conflicts:
#	cdc/scheduler/internal/base/processor_agent.go
# Conflicts:
#	cdc/scheduler/internal/base/processor_agent.go
@sdojjy
Copy link
Member Author

sdojjy commented May 13, 2022

/run-all-tests

@sdojjy
Copy link
Member Author

sdojjy commented May 13, 2022

/run-all-tests

@sdojjy
Copy link
Member Author

sdojjy commented May 13, 2022

/run-verify-test

@sdojjy
Copy link
Member Author

sdojjy commented May 14, 2022

/run-all-tests
/run-all-tests

@sdojjy sdojjy changed the base branch from master to decupple-tidb May 19, 2022 06:32
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 19, 2022
@sdojjy sdojjy merged commit 19de1e8 into pingcap:decupple-tidb May 19, 2022
sdojjy added a commit that referenced this pull request May 24, 2022
* cli support cdc cluster-id cmd flag
sdojjy added a commit that referenced this pull request Jun 7, 2022
* DNM *(ticdc): etcd key add cluster id and namespace (#5399)

* etcd key add cluster id and namespace

* DNM *(ticdc): cli support cdc cluster (#5412)

* cli support cdc cluster-id cmd flag

* DNM gc(ticdc):  gc service id refactor (#5444)

* refactor gc service id format

* tso use pd client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/cli CLI component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants