DNM gc(ticdc): gc service id refactor #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cdc/scheduler/internal/base/processor_agent.go
# Conflicts: # cdc/scheduler/internal/base/processor_agent.go
… cli-support-cdc-cluster-id
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5444 +/- ##
================================================
- Coverage 55.9233% 55.8655% -0.0579%
================================================
Files 528 527 -1
Lines 69935 69968 +33
================================================
- Hits 39110 39088 -22
- Misses 27100 27144 +44
- Partials 3725 3736 +11 |
|
/run-kafka-integration-test |
|
/run-integration-tests |
ti-chi-bot
added
size/L
nongfushanquan
approved these changes
May 19, 2022
|
@nongfushanquan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
sdojjy
added a commit
that referenced
this pull request
May 24, 2022
* refactor gc service id format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #5301
What is changed and how it works?
change the ticdc gc service id from "ticdc" to "ticdc--"
change the ensure gc service id prefix from "ticdc-creating-" to "ticdc---creating"
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note