Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinkV2(ticdc): sink manager close the sink factory at the last #8219

Merged
merged 3 commits into from
Feb 10, 2023
Merged

sinkV2(ticdc): sink manager close the sink factory at the last #8219

merged 3 commits into from
Feb 10, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8216

What is changed and how it works?

When close the sink manager, close the sink factory at the last, after make sure all sink workers exited.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Feb 10, 2023
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@3AceShowHand
Copy link
Contributor Author

/run-kafka-integration-test

@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@3AceShowHand
Copy link
Contributor Author

/run-verify-ci

@3AceShowHand
Copy link
Contributor Author

/run-integration-test

Rustin170506
Rustin170506 approved these changes Feb 10, 2023
View reviewed changes
cdc/processor/sinkmanager/manager.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 10, 2023
@3AceShowHand @Rustin170506
Update cdc/processor/sinkmanager/manager.go
1318a8a 
Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 10, 2023
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-6.6 Should cherry pick this PR to release-6.6 branch. label Feb 10, 2023
@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1318a8a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2023
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@3AceShowHand
Copy link
Contributor Author

/run-verify-ci

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/run-verify-ci

@ti-chi-bot ti-chi-bot merged commit be8b0c4 into pingcap:master Feb 10, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 10, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #8226.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 10, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8227.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 10, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#8219
caf2667 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Feb 10, 2023
@ti-chi-bot
sinkV2(ticdc): sink manager close the sink factory at the last (#8219) (
f5ed680 
#8226)

close #8216
ti-chi-bot added a commit that referenced this pull request Feb 14, 2023
@ti-chi-bot
sinkV2(ticdc): sink manager close the sink factory at the last (#8219) (
5db19d1 
#8227)

close #8216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@asddongmen asddongmen asddongmen approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 Should cherry pick this PR to release-6.6 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ticdc panic
4 participants
@3AceShowHand @ti-chi-bot @asddongmen @Rustin170506