-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sinkV2(ticdc): sink manager close the sink factory at the last (#8219) #8226
sinkV2(ticdc): sink manager close the sink factory at the last (#8219) #8226
Conversation
Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9262bab
|
/merge |
/run-verify-ci |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-6.6 #8226 +/- ##
================================================
Coverage ? 59.9265%
================================================
Files ? 809
Lines ? 92862
Branches ? 0
================================================
Hits ? 55649
Misses ? 32530
Partials ? 4683 |
/run-verify-ci |
/run-kafka-integration-test |
This is an automated cherry-pick of #8219
What problem does this PR solve?
Issue Number: close #8216
What is changed and how it works?
When close the sink manager, close the sink factory at the last, after make sure all sink workers exited.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note