-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorter(cdc): add config cache-size #9024
Conversation
Signed-off-by: qupeng <qupeng@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0dddffa
|
/test verify |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ref pingcap#8974 Signed-off-by: qupeng <qupeng@pingcap.com>
ref pingcap#8974 Signed-off-by: qupeng <qupeng@pingcap.com>
What problem does this PR solve?
Issue Number: ref #8974
What is changed and how it works?
#8982 sets
sorter.max-memory-percentage
to0
by default. It can cause an error:So we add a new config
sorter.cache-size
. The dafault value is128
, which means128M
.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note