Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter(cdc): add config cache-size #9024

Merged
merged 4 commits into from
May 23, 2023
Merged

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented May 23, 2023

What problem does this PR solve?

Issue Number: ref #8974

What is changed and how it works?

#8982 sets sorter.max-memory-percentage to 0 by default. It can cause an error:

[2023/05/18 23:44:57.290 +08:00] [DEBUG] [redo_log_worker.go:103] ["redo task finished"] [namespace=default] [changefeed=26b89b91-ab77-4438-b4bc-680e6ef6ab00] [span={table_id:90,start_key:7480000000000000ff5a5f720000000000fa,end_key:7480000000000000ff5a5f730000000000fa}] [lowerBound="{\"StartTs\":0,\"CommitTs\":441561825225998342}"] [upperBound="{\"StartTs\":441561826536718335,\"CommitTs\":441561826536718336}"] [lastPos="{\"StartTs\":441561825396129817,\"CommitTs\":441561825396129819}"] [lag=9.347587602] [error="msgp: attempted to decode type \"int\" with method for \"map\""] [errorVerbose="msgp: attempted to decode type \"int\" with method for \"map\"\ngithub.com/pingcap/errors.AddStack\n\t/home/qupeng/.go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/errors.go:174\ngithub.com/pingcap/errors.Trace\n\t/home/qupeng/.go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/juju_adaptor.go:15\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble/encoding.(*MsgPackGenSerde).Unmarshal\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble/encoding/value.go:45\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble.(*EventIter).Next\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble/event_sorter.go:362\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine.(*MountedEventIter).readBatch\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/mounted_iter.go:106\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine.(*MountedEventIter).Next\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/mounted_iter.go:63\ngithub.com/pingcap/tiflow/cdc/processor/sinkmanager.(*redoWorker).handleTask\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sinkmanager/redo_log_worker.go:120\ngithub.com/pingcap/tiflow/cdc/processor/sinkmanager.(*redoWorker).handleTasks\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sinkmanager/redo_log_worker.go:63\ngithub.com/pingcap/tiflow/cdc/processor/sinkmanager.(*SinkManager).startRedoWorkers.func1\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sinkmanager/manager.go:338\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\t/home/qupeng/.go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75\nruntime.goexit\n\t/home/qupeng/.local/opt/go1.20.1/src/runtime/asm_amd64.s:1598"]

So we add a new config sorter.cache-size. The dafault value is 128, which means 128M.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2023
pkg/config/sorter.go Outdated Show resolved Hide resolved
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2023
hicqu added 2 commits May 23, 2023 17:40
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2023
@hicqu
Copy link
Contributor Author

hicqu commented May 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0dddffa

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2023
@hicqu
Copy link
Contributor Author

hicqu commented May 23, 2023

/test verify

@ti-chi-bot ti-chi-bot bot merged commit 50d404d into pingcap:master May 23, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9029.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9030.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hicqu hicqu deleted the sorter-cache-size branch May 23, 2023 11:48
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request May 24, 2023
ti-chi-bot bot pushed a commit that referenced this pull request May 24, 2023
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request May 30, 2023
ref pingcap#8974

Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to ti-chi-bot/tiflow that referenced this pull request May 30, 2023
ref pingcap#8974

Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants