Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter(cdc): add config cache-size (#9024) #9029

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9024

What problem does this PR solve?

Issue Number: ref #8974

What is changed and how it works?

#8982 sets sorter.max-memory-percentage to 0 by default. It can cause an error:

[2023/05/18 23:44:57.290 +08:00] [DEBUG] [redo_log_worker.go:103] ["redo task finished"] [namespace=default] [changefeed=26b89b91-ab77-4438-b4bc-680e6ef6ab00] [span={table_id:90,start_key:7480000000000000ff5a5f720000000000fa,end_key:7480000000000000ff5a5f730000000000fa}] [lowerBound="{\"StartTs\":0,\"CommitTs\":441561825225998342}"] [upperBound="{\"StartTs\":441561826536718335,\"CommitTs\":441561826536718336}"] [lastPos="{\"StartTs\":441561825396129817,\"CommitTs\":441561825396129819}"] [lag=9.347587602] [error="msgp: attempted to decode type \"int\" with method for \"map\""] [errorVerbose="msgp: attempted to decode type \"int\" with method for \"map\"\ngithub.com/pingcap/errors.AddStack\n\t/home/qupeng/.go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/errors.go:174\ngithub.com/pingcap/errors.Trace\n\t/home/qupeng/.go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/juju_adaptor.go:15\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble/encoding.(*MsgPackGenSerde).Unmarshal\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble/encoding/value.go:45\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble.(*EventIter).Next\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/pebble/event_sorter.go:362\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine.(*MountedEventIter).readBatch\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/mounted_iter.go:106\ngithub.com/pingcap/tiflow/cdc/processor/sourcemanager/engine.(*MountedEventIter).Next\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sourcemanager/engine/mounted_iter.go:63\ngithub.com/pingcap/tiflow/cdc/processor/sinkmanager.(*redoWorker).handleTask\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sinkmanager/redo_log_worker.go:120\ngithub.com/pingcap/tiflow/cdc/processor/sinkmanager.(*redoWorker).handleTasks\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sinkmanager/redo_log_worker.go:63\ngithub.com/pingcap/tiflow/cdc/processor/sinkmanager.(*SinkManager).startRedoWorkers.func1\n\t/home/qupeng/.go/src/github.com/pingcap/tiflow/cdc/processor/sinkmanager/manager.go:338\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\t/home/qupeng/.go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75\nruntime.goexit\n\t/home/qupeng/.local/opt/go1.20.1/src/runtime/asm_amd64.s:1598"]

So we add a new config sorter.cache-size. The dafault value is 128, which means 128M.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels May 23, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels May 23, 2023
@hicqu hicqu force-pushed the cherry-pick-9024-to-release-7.1 branch from 807d4e9 to 7f84fb4 Compare May 24, 2023 03:09
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 24, 2023
@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 7f84fb4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2023
@nongfushanquan
Copy link
Contributor

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nongfushanquan
Copy link
Contributor

/retest

@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test verify

5 similar comments
@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test verify

@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test verify

@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test verify

@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test verify

@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test verify

@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test dm-integration-test

@hicqu
Copy link
Contributor

hicqu commented May 24, 2023

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit c0fa293 into pingcap:release-7.1 May 24, 2023
@hicqu hicqu deleted the cherry-pick-9024-to-release-7.1 branch May 27, 2023 05:50
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants