-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorter(cdc): add config cache-size (#9024) #9029
sorter(cdc): add config cache-size (#9024) #9029
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
807d4e9
to
7f84fb4
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7f84fb4
|
/retest |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
/test verify |
5 similar comments
/test verify |
/test verify |
/test verify |
/test verify |
/test verify |
/test dm-integration-test |
/test dm-integration-test |
This is an automated cherry-pick of #9024
What problem does this PR solve?
Issue Number: ref #8974
What is changed and how it works?
#8982 sets
sorter.max-memory-percentage
to0
by default. It can cause an error:So we add a new config
sorter.cache-size
. The dafault value is128
, which means128M
.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note