Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shade io.opencensus to resolve grpc conflict #1345

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Conversation

birdstorm
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

The issue states back to when we update grpc to 1.17 in #982, io.opencensus was introduced but not properly shaded.

Check List

Tests

  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Contributor Author

/run-all-tests

@birdstorm birdstorm merged commit 0bb9360 into master Jan 3, 2020
@birdstorm birdstorm deleted the shade-opencensus branch January 3, 2020 05:25
@you06
Copy link

you06 commented Jan 3, 2020

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Jan 3, 2020

cherry pick to release-2.1 in PR #1352

@sre-bot
Copy link
Contributor

sre-bot commented Jan 3, 2020

cherry pick to release-2.2 in PR #1353

wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants