Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shade io.opencensus to resolve grpc conflict (#1345) #1352

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 3, 2020

cherry-pick #1345 to release-2.1


What problem does this PR solve?

What is changed and how it works?

The issue states back to when we update grpc to 1.17 in #982, io.opencensus was introduced but not properly shaded.

Check List

Tests

  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm merged commit 1b46121 into pingcap:release-2.1 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants