fix --ignore-config-check not working for deploy (#1774)

components/cluster/command/deploy.go

@@ -73,7 +73,7 @@ func newDeploy() *cobra.Command {
 	cmd.Flags().BoolVarP(&opt.SkipCreateUser, "skip-create-user", "", false, "(EXPERIMENTAL) Skip creating the user specified in topology.")
 	cmd.Flags().StringVarP(&opt.IdentityFile, "identity_file", "i", opt.IdentityFile, "The path of the SSH identity file. If specified, public key authentication will be used.")
 	cmd.Flags().BoolVarP(&opt.UsePassword, "password", "p", false, "Use password of target hosts. If specified, password authentication will be used.")
-	cmd.Flags().BoolVarP(&opt.IgnoreConfigCheck, "ignore-config-check", "", opt.IgnoreConfigCheck, "Ignore the config check result")
+	cmd.Flags().BoolVarP(&gOpt.IgnoreConfigCheck, "ignore-config-check", "", false, "Ignore the config check result of components")
 	cmd.Flags().BoolVarP(&opt.NoLabels, "no-labels", "", false, "Don't check TiKV labels")
 
 	return cmd

pkg/cluster/manager/deploy.go

@@ -40,14 +40,13 @@ import (
 
 // DeployOptions contains the options for scale out.
 type DeployOptions struct {
-	User              string // username to login to the SSH server
-	SkipCreateUser    bool   // don't create the user
-	IdentityFile      string // path to the private key file
-	UsePassword       bool   // use password instead of identity file for ssh connection
-	IgnoreConfigCheck bool   // ignore config check result
-	NoLabels          bool   // don't check labels for TiKV instance
-	Stage1            bool   // don't start the new instance, just deploy
-	Stage2            bool   // start instances and init Config after stage1
+	User           string // username to login to the SSH server
+	SkipCreateUser bool   // don't create the user
+	IdentityFile   string // path to the private key file
+	UsePassword    bool   // use password instead of identity file for ssh connection
+	NoLabels       bool   // don't check labels for TiKV instance
+	Stage1         bool   // don't start the new instance, just deploy
+	Stage2         bool   // start instances and init Config after stage1
 }
 
 // DeployerInstance is a instance can deploy to a target deploy directory.