-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix --ignore-config-check not working for deploy #1774
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
==========================================
- Coverage 53.21% 53.14% -0.08%
==========================================
Files 303 303
Lines 34436 34436
==========================================
- Hits 18325 18299 -26
- Misses 13967 13985 +18
- Partials 2144 2152 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bb37c16
|
What problem does this PR solve?
fix #1773
What is changed and how it works?
There were two
IgnoreConfigCheck
fields, and the one inDeployOptions
was never used (it was moved tooperator.Options
about a year ago)Check List
Tests
Code changes
Release notes: