Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.0 check thp always fail #1006

Closed
sultan8252 opened this issue Dec 22, 2020 · 2 comments
Closed

v1.3.0 check thp always fail #1006

sultan8252 opened this issue Dec 22, 2020 · 2 comments
Labels
type/bug Categorizes issue as related to a bug.

Comments

@sultan8252
Copy link

Bug Report

When split string result, there is a \n at the end, resulting in an additional'' element in the list. Therefore, it is necessary to enter the fail process when determining whether it contains the [never] string.
bug point: https://github.com/pingcap/tiup/blob/v1.3.0/pkg/cluster/operation/check.go#L672-L677
Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    tiup cluster check --cluster {cluster-name}

  2. What did you expect to see?
    always report fail

  3. What did you see instead?

  4. What version of TiUP are you using (tiup --version)?
    v1.3.0

@sultan8252 sultan8252 added the type/bug Categorizes issue as related to a bug. label Dec 22, 2020
@dveeden
Copy link
Contributor

dveeden commented Jan 25, 2022

This has been fixed by @lucklove in #1005
/close

@ti-chi-bot
Copy link
Member

@dveeden: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

This has been fixed by @lucklove in #1005
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Categorizes issue as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants