Fix tail newline on thp check #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced by pingcap#964 There is a newline at the end of output of cat command, so the '[never]' check will fail on the empty newline.
ti-chi-bot
added
the
size/XS
lucklove
added
type/bug-fix
ti-chi-bot
added
the
size/XS
|
/lgtm |
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
This pull request has been accepted and is ready to merge. Commit hash: 26748bb
|
lucklove
added a commit
that referenced
this pull request
Dec 31, 2020
Introduced by #964 There is a newline at the end of output of cat command, so the '[never]' check will fail on the empty newline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #964
Related issue: #1006
There is a newline at the end of output of cat command,
so the '[never]' check will fail on the empty newline.