Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: support specify PD port #1833

Closed
pingyu opened this issue Apr 4, 2022 · 0 comments · Fixed by #1931
Closed

playground: support specify PD port #1833

pingyu opened this issue Apr 4, 2022 · 0 comments · Fixed by #1931
Labels
type/feature-request Categorizes issue as related to a new feature.

Comments

@pingyu
Copy link
Contributor

pingyu commented Apr 4, 2022

Feature Request

Is your feature request related to a problem? Please describe:

I use TiKV as a key-value service, with PD port as service entry point.

  • Scene 1
    On a shared server, if the 2379 is occupied by others, the port of PD is changed after every restart.
  • Scene 2
    For some automatic integration test cases that need more than one cluster (e.g., backup & restore, change data capture), it is tedious to parse output of TiUP to acquire the PD port of the second cluster.

Describe the feature you'd like:

Support specify PD port in playground.

Why the featue is needed:

To be convenient for TiKV developers. The scenarios is very similar to db.port for TiDB users.

Describe alternatives you've considered:

Add an optional pd.port argument for tiup playground, and set Port of PDInstance to utils.MustGetFreePort(pd.host, pd.port).

Teachability, Documentation, Adoption, Migration Strategy:

@pingyu pingyu added the type/feature-request Categorizes issue as related to a new feature. label Apr 4, 2022
pingyu added a commit to pingyu/tiup that referenced this issue Jun 20, 2022
Issue: pingcap#1833

Signed-off-by: pingyu <yuping@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant