Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: add pd.port argument #1931

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Jun 20, 2022

Issue: #1833

Signed-off-by: pingyu yuping@pingcap.com

What problem does this PR solve?

Close: #1833

What is changed and how it works?

Add pd.port argument.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
bin/tiup-playground v6.1.0 --db 0 --tiflash 0 --kv 1 --pd 1 --pd.port 32379
Playground Bootstrapping...
Start pd instance:v6.1.0
Start tikv instance:v6.1.0
PD client endpoints: [127.0.0.1:32379]
To view the Prometheus: http://127.0.0.1:35411
To view the Grafana: http://127.0.0.1:33691

Code changes

Side effects

Related changes

Release notes:

Add `pd.port` argument to specify PD port of playground.

Issue: pingcap#1833

Signed-off-by: pingyu <yuping@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2022

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #1931 (823a737) into master (2de5b50) will decrease coverage by 13.25%.
The diff coverage is 100.00%.

❗ Current head 823a737 differs from pull request most recent head 3ebadd5. Consider uploading reports for the commit 3ebadd5 to get more accurate results

@@             Coverage Diff             @@
##           master    #1931       +/-   ##
===========================================
- Coverage   52.54%   39.29%   -13.25%     
===========================================
  Files         307      306        -1     
  Lines       35462    35451       -11     
===========================================
- Hits        18631    13929     -4702     
- Misses      14637    19622     +4985     
+ Partials     2194     1900      -294     
Flag Coverage Δ
cluster 28.90% <ø> (-12.20%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/pd.go 73.44% <100.00%> (ø)
components/playground/main.go 46.17% <100.00%> (ø)
components/playground/playground.go 49.48% <100.00%> (ø)
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-77.94%) ⬇️
pkg/cluster/template/config/ngmonitoring.go 0.00% <0.00%> (-76.47%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de5b50...3ebadd5. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
@AstroProfundis AstroProfundis added this to the v1.11.0 milestone Jun 20, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3ebadd5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@ti-chi-bot ti-chi-bot merged commit 44a1257 into pingcap:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playground: support specify PD port
5 participants