-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: add pd.port argument #1931
Conversation
Issue: pingcap#1833 Signed-off-by: pingyu <yuping@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
===========================================
- Coverage 52.54% 39.29% -13.25%
===========================================
Files 307 306 -1
Lines 35462 35451 -11
===========================================
- Hits 18631 13929 -4702
- Misses 14637 19622 +4985
+ Partials 2194 1900 -294
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3ebadd5
|
Issue: #1833
Signed-off-by: pingyu yuping@pingcap.com
What problem does this PR solve?
Close: #1833
What is changed and how it works?
Add
pd.port
argument.Check List
Tests
Code changes
Side effects
Related changes
Release notes: