Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: only pull nightly from cluster version #2364

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 15, 2024

What problem does this PR solve?

tiup playground v7.5.0 --tiproxy 1 will fail since bindVersion = "v7.5.0". We should only pull nightly instead.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack January 15, 2024 09:24
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (79c584f) 55.78% compared to head (22d4bbb) 54.51%.

❗ Current head 22d4bbb differs from pull request most recent head c5007e6. Consider uploading reports for the commit c5007e6 to get more accurate results

Files Patch % Lines
components/playground/playground.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2364      +/-   ##
==========================================
- Coverage   55.78%   54.51%   -1.27%     
==========================================
  Files         329      329              
  Lines       35024    35783     +759     
==========================================
- Hits        19537    19507      -30     
- Misses      13143    13940     +797     
+ Partials     2344     2336       -8     
Flag Coverage Δ
playground 15.19% <0.00%> (-0.14%) ⬇️
tiup 33.60% <ø> (ø)
unittest 22.33% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added lgtm and removed lgtm labels Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 2, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Feb 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 2, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 09:33:17.63350607 +0000 UTC m=+175639.197803760: ☑️ agreed by kaaaaaaang.
  • 2024-01-15 13:49:53.966759728 +0000 UTC m=+191035.531057434: ✖️🔁 reset by xhebox.
  • 2024-02-02 09:49:24.279926773 +0000 UTC m=+1731805.844224478: ☑️ agreed by kaaaaaaang.
  • 2024-02-02 09:49:40.490085395 +0000 UTC m=+1731822.054383100: ✖️🔁 reset by ti-chi-bot[bot].
  • 2024-02-02 09:54:45.232361872 +0000 UTC m=+1732126.796659579: ☑️ agreed by kaaaaaaang.

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 38b6c96 into pingcap:master Feb 2, 2024
7 checks passed
kaaaaaaang added a commit that referenced this pull request Apr 1, 2024
kaaaaaaang added a commit that referenced this pull request Apr 3, 2024
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants