Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "playground: only pull nightly from cluster version (#2364)" #2397

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

kaaaaaaang
Copy link
Collaborator

@kaaaaaaang kaaaaaaang commented Apr 1, 2024

This reverts commit 38b6c96.

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar April 1, 2024 12:29
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kaaaaaaang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.83%. Comparing base (48f15f4) to head (db3303b).

❗ Current head db3303b differs from pull request most recent head 1a90efb. Consider uploading reports for the commit 1a90efb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
+ Coverage   55.80%   55.83%   +0.03%     
==========================================
  Files         329      329              
  Lines       35222    35221       -1     
==========================================
+ Hits        19654    19663       +9     
+ Misses      13202    13187      -15     
- Partials     2366     2371       +5     
Flag Coverage Δ
playground 16.52% <100.00%> (+0.16%) ⬆️
tiup 33.59% <ø> (ø)
unittest 22.16% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang added this to the v1.15.1 milestone Apr 3, 2024
@kaaaaaaang kaaaaaaang merged commit 6f01692 into master Apr 3, 2024
6 of 7 checks passed
@kaaaaaaang kaaaaaaang deleted the revert-2364-master branch April 3, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup playground can not deploy a right version cluster
2 participants