Issue#149 differential evolution mcmc #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to add more recent DE variants.
Need to (ideall) allow for burn-in selection of crossover distribution as per the paper.
Including a comment to ignore flake8 on a few lines as it is stopping me write perfectly fine code due to alignment.
chonlei
reviewed
Dec 28, 2017
| "pints.plot.pairwise(stacked, kde=False)\n", | ||
| "\n", | ||
| "plt.show()" | ||
|
|
There was a problem hiding this comment.
We probably want the examples to be more consistent. We can either split the two examples or we can also do one that use the same data and compare the performance of different MCMC algorithms?
I will split the two first.
| self._num_chains = num_chains | ||
|
|
||
|
|
||
| def R_draw(i, num_chains): |
There was a problem hiding this comment.
Should we make this to a hidden method? e.g. _R_draw and add some comments?
|
|
||
| 1. Select proposal: | ||
|
|
||
| x_proposed = x[i,r] + (1 + e) * gamma(delta, d, p_g) * |
There was a problem hiding this comment.
Can we possibly use LaTex format? Probably hard to read these equations in the documentation. (see above -- line 217)
|
|
||
|
|
||
| class DreamMCMC(pints.MCMC): | ||
| """ |
There was a problem hiding this comment.
Can we do something like r""" ... $equation$ ... """ to make things in LaTex format? @MichaelClerx probably have more ideas on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.