Fix linter errors

golangci-lint upgrade to v1.56.2 added more checks Relates to pion/.goassets#201
pion · Mar 17, 2024 · b71802f · b71802f
1 parent 99f146f
commit b71802f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/vnet/conn_test.go b/vnet/conn_test.go
@@ -62,7 +62,7 @@ func TestUDPConn(t *testing.T) {
 				conn.readCh <- chunk // echo back
 				return nil
 			},
-			onOnClosed: func(addr net.Addr) {
+			onOnClosed: func(net.Addr) {
 				atomic.AddInt32(&nClosed, 1)
 			},
 		}
@@ -143,7 +143,7 @@ func TestUDPConn(t *testing.T) {
 				conn.readCh <- chunk // echo back
 				return nil
 			},
-			onOnClosed: func(addr net.Addr) {
+			onOnClosed: func(net.Addr) {
 				atomic.AddInt32(&nClosed, 1)
 			},
 		}
@@ -204,7 +204,7 @@ func TestUDPConn(t *testing.T) {
 			Port: 1234,
 		}
 		obs := &dummyObserver{
-			onOnClosed: func(addr net.Addr) {
+			onOnClosed: func(net.Addr) {
 				atomic.AddInt32(&nClosed, 1)
 			},
 		}

diff --git a/vnet/router_test.go b/vnet/router_test.go
@@ -348,7 +348,7 @@ func TestRouterDelay(t *testing.T) {
 			var delayRes []time.Duration
 			nPkts := 1
 
-			nic[0].onInboundChunkHandler = func(c Chunk) {}
+			nic[0].onInboundChunkHandler = func(Chunk) {}
 
 			nic[1].onInboundChunkHandler = func(c Chunk) {
 				delay := time.Since(c.getTimestamp())

diff --git a/vnet/udpproxy.go b/vnet/udpproxy.go
@@ -55,7 +55,7 @@ func NewProxy(router *Router) (*UDPProxy, error) {
 
 // Close the proxy, stop all workers.
 func (v *UDPProxy) Close() error {
-	v.workers.Range(func(key, value interface{}) bool {
+	v.workers.Range(func(_, value interface{}) bool {
 		_ = value.(*aUDPProxyWorker).Close() //nolint:forcetypeassert
 		return true
 	})

diff --git a/vnet/udpproxy_direct.go b/vnet/udpproxy_direct.go
@@ -11,7 +11,7 @@ import (
 // Deliver directly send packet to vnet or real-server.
 // For example, we can use this API to simulate the REPLAY ATTACK.
 func (v *UDPProxy) Deliver(sourceAddr, destAddr net.Addr, b []byte) (nn int, err error) {
-	v.workers.Range(func(key, value interface{}) bool {
+	v.workers.Range(func(_, value interface{}) bool {
 		if nn, err = value.(*aUDPProxyWorker).Deliver(sourceAddr, destAddr, b); err != nil {
 			return false // Fail, abort.
 		} else if nn == len(b) {

diff --git a/vnet/udpproxy_direct_test.go b/vnet/udpproxy_direct_test.go
@@ -329,9 +329,9 @@ func TestUDPProxyDirectDeliverBadCase(t *testing.T) {
 			}
 
 			// BadCase: Write on closed socket, error and ignore.
-			proxy.workers.Range(func(key, value interface{}) bool {
+			proxy.workers.Range(func(_, value interface{}) bool {
 				//nolint:forcetypeassert
-				value.(*aUDPProxyWorker).endpoints.Range(func(key, value interface{}) bool {
+				value.(*aUDPProxyWorker).endpoints.Range(func(_, value interface{}) bool {
 					_ = value.(*net.UDPConn).Close() //nolint:forcetypeassert
 					return true
 				})