Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#196 introduced a lot of new lint errors #201

Closed
at-wat opened this issue Mar 4, 2024 · 2 comments
Closed

#196 introduced a lot of new lint errors #201

at-wat opened this issue Mar 4, 2024 · 2 comments
Assignees

Comments

@at-wat
Copy link
Member

at-wat commented Mar 4, 2024

#196 seems introduced a lot of new lint errors:
https://github.com/pion/webrtc/actions/runs/8089732277/job/22106111066?pr=2685#step:5:25

  Running [/home/runner/golangci-lint-1.56.2-linux-amd64/golangci-lint run --out-format=github-actions $GOLANGCI_LINT_EXRA_ARGS] in [] ...
  Warning: unused-parameter: parameter 'headPacket' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'o' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'id' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'attributes' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pair' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'cs' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'ss' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pcs' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'ics' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'trackRemote' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'midValue' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'm' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
  
  Error: issues found
  Ran golangci-lint in 33923ms

Originally posted by @at-wat in #196 (comment)

@Sean-Der
Copy link
Member

Sean-Der commented Mar 4, 2024

👍 I will go and disable these linters!

The issue was that golangci-lint wasn't working with newer versions of Go

Sean-Der added a commit to pion/example-webrtc-applications that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/ice that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/dtls that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/interceptor that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/mdns that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/opus that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/explainer that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/randutil that referenced this issue Mar 16, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/stun that referenced this issue Mar 17, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/transport that referenced this issue Mar 17, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/turn that referenced this issue Mar 17, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sean-Der added a commit to pion/webrtc that referenced this issue Mar 17, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
@Sean-Der
Copy link
Member

I have fixed the code across all repos, thanks for filing this @at-wat

Sean-Der added a commit to pion/stun that referenced this issue Apr 3, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
ourwarmhouse added a commit to ourwarmhouse/Smart-Contract---Go that referenced this issue May 1, 2024
golangci-lint upgrade to v1.56.2 added more checks

Relates to pion/.goassets#201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants