SampleBuilder: Add option to return RTPHeaders #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2687 +/- ##
==========================================
+ Coverage 76.42% 76.51% +0.09%
==========================================
Files 87 87
Lines 9928 9934 +6
==========================================
+ Hits 7587 7601 +14
+ Misses 1870 1865 -5
+ Partials 471 468 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Replaces fa1f5d9 which returned only a head packet's header. When the option WithRTPHeaders is set, SampleBuilder returns RTP headers of the packets forming the sample as Sample.RTPHeaders.
at-wat
force-pushed
the
samplebuilder/add-option-to-return-rtp-headers
branch
from
35243cb to
f467562
Compare
tmatth
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2681 which returned only a head packet's header.
When the option WithRTPHeaders is set, SampleBuilder returns RTP headers of the packets forming the sample as Sample.RTPHeaders.
This feature is useful for getting RTP extension data associated with the sample
Lint job is failing due to pion/.goassets#201
reference