Add postSync configuration as part of DeploymentConfiguration

[khanhtc1202]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

[pipecd-bot]

Code coverage for golang is 31.98%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.GetDeployment	--	0.00%	+0.00%
pkg/config/deployment.go	DeploymentChainNode.Validate	--	75.00%	+75.00%
pkg/config/deployment.go	PostSync.Validate	--	62.50%	+62.50%
pkg/config/deployment.go	GenericDeploymentSpec.Validate	53.85%	56.25%	+2.40%

[pipecd-bot]

Code coverage for golang is 31.98%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.GetDeployment	--	0.00%	+0.00%
pkg/config/deployment.go	PostSync.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChain.Validate	--	55.56%	+55.56%
pkg/config/deployment.go	DeploymentChainNode.Validate	--	75.00%	+75.00%
pkg/config/deployment.go	DeploymentChainTriggerCondition.Validate	--	0.00%	+0.00%
pkg/config/deployment.go	GenericDeploymentSpec.Validate	53.85%	56.25%	+2.40%

[pipecd-bot]

Code coverage for golang is 31.98%. This pull request increases coverage by 0.01%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.GetDeployment	--	0.00%	+0.00%
pkg/config/deployment.go	PostSync.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChain.Validate	--	55.56%	+55.56%
pkg/config/deployment.go	DeploymentChainNode.Validate	--	75.00%	+75.00%
pkg/config/deployment.go	DeploymentChainTriggerCondition.Validate	--	0.00%	+0.00%
pkg/config/deployment.go	GenericDeploymentSpec.Validate	53.85%	56.25%	+2.40%

[pipecd-bot]

Code coverage for golang is 31.98%. This pull request increases coverage by 0.01%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.GetDeployment	--	0.00%	+0.00%
pkg/config/deployment.go	PostSync.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChain.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChainNode.Validate	--	75.00%	+75.00%
pkg/config/deployment.go	DeploymentChainTriggerCondition.Validate	--	0.00%	+0.00%
pkg/config/deployment.go	GenericDeploymentSpec.Validate	53.85%	56.25%	+2.40%

[nghialv]

/lgtm

[nakabonne]

The above is not related to this topic directly, there you go anyway!
/approve

[nakabonne]

TestGenericPostSyncConfiguration failed 👀

[pipecd-bot]

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

[khanhtc1202]

/golinter trigger

[pipecd-bot]

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

[khanhtc1202]

/golinter trigger

[pipecd-bot]

Code coverage for javascript is 84.24%. This pull request does not change code coverage.

[pipecd-bot]

Code coverage for golang is 31.92%. This pull request decreases coverage by -0.05%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.GetDeployment	--	0.00%	+0.00%
pkg/app/piped/trigger/determiner.go	NewOnCommandDeterminer	--	0.00%	+0.00%
pkg/app/piped/trigger/determiner.go	NewOnOutOfSyncDeterminer	--	0.00%	+0.00%
pkg/config/deployment.go	PostSync.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChain.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChainNode.Validate	--	75.00%	+75.00%
pkg/config/deployment.go	DeploymentChainTriggerCondition.Validate	--	0.00%	+0.00%
pkg/app/piped/trigger/determiner.go	OnOutOfSyncDeterminer.ShouldTrigger	0.00%	0.00%	+0.00%
pkg/app/piped/trigger/trigger.go	Trigger.checkRepoCandidates	0.00%	0.00%	+0.00%
pkg/config/deployment.go	GenericDeploymentSpec.Validate	53.85%	56.25%	+2.40%

[pipecd-bot]

Code coverage for javascript is 84.24%. This pull request does not change code coverage.

[nghialv]

Could you rebase this PR?
The diff looks weird.

[pipecd-bot]

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

---

1. Add conditions to deployment chain configuration.

https://github.com/pipe-cd/pipe/blob/16ebd838c6be56f29c4b061d5914f1cdf6e7c518/pkg/config/deployment.go#L558-L561

This was created by todo plugin since "TODO:" was found in 16ebd83 when #2792 was merged. cc: @khanhtc1202.

[nghialv]

/approve

[khanhtc1202]

Could you rebase this PR? The diff looks weird.

Done, PTAL 🙏

[khanhtc1202]

/approve cancel

[pipecd-bot]

Code coverage for golang is 31.92%. This pull request increases coverage by 0.03%.

File	Function	Base	Head	Diff
pkg/config/deployment.go	PostSync.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChain.Validate	--	66.67%	+66.67%
pkg/config/deployment.go	DeploymentChainNode.Validate	--	75.00%	+75.00%
pkg/config/deployment.go	DeploymentChainTriggerCondition.Validate	--	0.00%	+0.00%
pkg/config/deployment.go	GenericDeploymentSpec.Validate	53.85%	56.25%	+2.40%

[nghialv]

/approve

[pipecd-bot]

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.