-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable appconfig reporter in Piped #2868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -45,7 +45,7 @@ import ( | |||
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/deploymentstore" | |||
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/environmentstore" | |||
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/eventstore" | |||
"github.com/pipe-cd/pipe/pkg/app/piped/appconfigreporter" | |||
_ "github.com/pipe-cd/pipe/pkg/app/piped/appconfigreporter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a blank import should be only in a main or test package, or have a comment justifying it
/approve |
/changelog |
@nghialv: Changelog has been generated in response to this comment. DetailsChangelog since v0.21.1Notable Changes
Internal Changes
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: