Delete platform specific codes from pipedv1 (#5051)

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>

pkg/app/piped/cmd/piped/piped.go

@@ -53,7 +53,6 @@ import (
 	"github.com/pipe-cd/pipecd/pkg/app/piped/controller/controllermetrics"
 	"github.com/pipe-cd/pipecd/pkg/app/piped/driftdetector"
 	"github.com/pipe-cd/pipecd/pkg/app/piped/eventwatcher"
-	"github.com/pipe-cd/pipecd/pkg/app/piped/livestatereporter"
 	"github.com/pipe-cd/pipecd/pkg/app/piped/livestatestore"
 	k8slivestatestoremetrics "github.com/pipe-cd/pipecd/pkg/app/piped/livestatestore/kubernetes/kubernetesmetrics"
 	"github.com/pipe-cd/pipecd/pkg/app/piped/notifier"
@@ -356,14 +355,6 @@ func (p *piped) run(ctx context.Context, input cli.Input) (runErr error) {
 		liveStateGetter = s.Getter()
 	}
 
-	// Start running application live state reporter.
-	{
-		r := livestatereporter.NewReporter(applicationLister, liveStateGetter, apiClient, cfg, input.Logger)
-		group.Go(func() error {
-			return r.Run(ctx)
-		})
-	}
-
 	decrypter, err := p.initializeSecretDecrypter(cfg)
 	if err != nil {
 		input.Logger.Error("failed to initialize secret decrypter", zap.Error(err))
@@ -375,7 +366,6 @@ func (p *piped) run(ctx context.Context, input cli.Input) (runErr error) {
 		d, err := driftdetector.NewDetector(
 			applicationLister,
 			gitClient,
-			liveStateGetter,
 			apiClient,
 			appManifestsCache,
 			cfg,

pkg/app/piped/driftdetector/detector.go

@@ -27,10 +27,6 @@ import (
 	"golang.org/x/sync/errgroup"
 	"google.golang.org/grpc"
 
-	"github.com/pipe-cd/pipecd/pkg/app/piped/driftdetector/cloudrun"
-	"github.com/pipe-cd/pipecd/pkg/app/piped/driftdetector/kubernetes"
-	"github.com/pipe-cd/pipecd/pkg/app/piped/driftdetector/terraform"
-	"github.com/pipe-cd/pipecd/pkg/app/piped/livestatestore"
 	"github.com/pipe-cd/pipecd/pkg/app/server/service/pipedservice"
 	"github.com/pipe-cd/pipecd/pkg/cache"
 	"github.com/pipe-cd/pipecd/pkg/config"
@@ -78,7 +74,6 @@ type providerDetector interface {
 func NewDetector(
 	appLister applicationLister,
 	gitClient gitClient,
-	stateGetter livestatestore.Getter,
 	apiClient apiClient,
 	appManifestsCache cache.Cache,
 	cfg *config.PipedSpec,
@@ -97,60 +92,6 @@ func NewDetector(
 
 	for _, cp := range cfg.PlatformProviders {
 		switch cp.Type {
-		case model.PlatformProviderKubernetes:
-			sg, ok := stateGetter.KubernetesGetter(cp.Name)
-			if !ok {
-				return nil, fmt.Errorf(format, cp.Name)
-			}
-			d.detectors = append(d.detectors, kubernetes.NewDetector(
-				cp,
-				appLister,
-				gitClient,
-				sg,
-				d,
-				appManifestsCache,
-				cfg,
-				sd,
-				logger,
-			))
-
-		case model.PlatformProviderCloudRun:
-			sg, ok := stateGetter.CloudRunGetter(cp.Name)
-			if !ok {
-				return nil, fmt.Errorf(format, cp.Name)
-			}
-			d.detectors = append(d.detectors, cloudrun.NewDetector(
-				cp,
-				appLister,
-				gitClient,
-				sg,
-				d,
-				appManifestsCache,
-				cfg,
-				sd,
-				logger,
-			))
-
-		case model.PlatformProviderTerraform:
-			if !*cp.TerraformConfig.DriftDetectionEnabled {
-				continue
-			}
-			sg, ok := stateGetter.TerraformGetter(cp.Name)
-			if !ok {
-				return nil, fmt.Errorf(format, cp.Name)
-			}
-			d.detectors = append(d.detectors, terraform.NewDetector(
-				cp,
-				appLister,
-				gitClient,
-				sg,
-				d,
-				appManifestsCache,
-				cfg,
-				sd,
-				logger,
-			))
-
 		default:
 		}
 	}

pkg/app/piped/livestatereporter/reporter.go

@@ -25,9 +25,6 @@ import (
 	"golang.org/x/sync/errgroup"
 	"google.golang.org/grpc"
 
-	"github.com/pipe-cd/pipecd/pkg/app/piped/livestatereporter/cloudrun"
-	"github.com/pipe-cd/pipecd/pkg/app/piped/livestatereporter/kubernetes"
-	"github.com/pipe-cd/pipecd/pkg/app/piped/livestatestore"
 	"github.com/pipe-cd/pipecd/pkg/app/server/service/pipedservice"
 	"github.com/pipe-cd/pipecd/pkg/config"
 	"github.com/pipe-cd/pipecd/pkg/model"
@@ -56,7 +53,7 @@ type providerReporter interface {
 	ProviderName() string
 }
 
-func NewReporter(appLister applicationLister, stateGetter livestatestore.Getter, apiClient apiClient, cfg *config.PipedSpec, logger *zap.Logger) Reporter {
+func NewReporter(appLister applicationLister, apiClient apiClient, cfg *config.PipedSpec, logger *zap.Logger) Reporter {
 	r := &reporter{
 		reporters: make([]providerReporter, 0, len(cfg.PlatformProviders)),
 		logger:    logger.Named("live-state-reporter"),
@@ -65,20 +62,6 @@ func NewReporter(appLister applicationLister, stateGetter livestatestore.Getter,
 	const errFmt = "unable to find live state getter for platform provider: %s"
 	for _, cp := range cfg.PlatformProviders {
 		switch cp.Type {
-		case model.PlatformProviderKubernetes:
-			sg, ok := stateGetter.KubernetesGetter(cp.Name)
-			if !ok {
-				r.logger.Error(fmt.Sprintf(errFmt, cp.Name))
-				continue
-			}
-			r.reporters = append(r.reporters, kubernetes.NewReporter(cp, appLister, sg, apiClient, logger))
-		case model.PlatformProviderCloudRun:
-			sg, ok := stateGetter.CloudRunGetter(cp.Name)
-			if !ok {
-				r.logger.Error(fmt.Sprintf(errFmt, cp.Name))
-				continue
-			}
-			r.reporters = append(r.reporters, cloudrun.NewReporter(cp, appLister, sg, apiClient, logger))
 		}
 	}