Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete platform specific codes from pipedv1 #5051

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jul 17, 2024

What this PR does / why we need it:

This PR deletes the platform-specific codes from pipedv1.
Because pipedv1 uses a plugin architecture to implement platform-specific operations, platform-specific codes are not needed except for plugin implementations.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Warashi Warashi enabled auto-merge (squash) July 17, 2024 08:26
@Warashi Warashi disabled auto-merge July 17, 2024 08:26
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.74%. Comparing base (35f0408) to head (cdc4f01).

Files Patch % Lines
pkg/app/piped/livestatereporter/reporter.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/livestatestore/livestatestore.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5051      +/-   ##
==========================================
+ Coverage   22.45%   22.74%   +0.28%     
==========================================
  Files         522      406     -116     
  Lines       57026    43041   -13985     
==========================================
- Hits        12807     9790    -3017     
+ Misses      43192    32473   -10719     
+ Partials     1027      778     -249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 merged commit eca1f46 into master Jul 17, 2024
17 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-platform-code-from-pipedv1 branch July 17, 2024 08:50
Warashi added a commit that referenced this pull request Jul 18, 2024
Warashi added a commit that referenced this pull request Jul 18, 2024
This reverts commit eca1f46.

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi added a commit that referenced this pull request Jul 18, 2024
This reverts commit eca1f46.

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
This was referenced Jul 18, 2024
@khanhtc1202 khanhtc1202 restored the remove-platform-code-from-pipedv1 branch July 19, 2024 08:30
This was referenced Jul 29, 2024
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants