-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete platform specific codes from pipedv1 #5051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
July 17, 2024 08:25
khanhtc1202
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5051 +/- ##
==========================================
+ Coverage 22.45% 22.74% +0.28%
==========================================
Files 522 406 -116
Lines 57026 43041 -13985
==========================================
- Hits 12807 9790 -3017
+ Misses 43192 32473 -10719
+ Partials 1027 778 -249 ☔ View full report in Codecov by Sentry. |
ffjlabo
approved these changes
Jul 17, 2024
Warashi
added a commit
that referenced
this pull request
Jul 18, 2024
This reverts commit eca1f46. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
added a commit
that referenced
this pull request
Jul 18, 2024
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR deletes the platform-specific codes from pipedv1.
Because pipedv1 uses a plugin architecture to implement platform-specific operations, platform-specific codes are not needed except for plugin implementations.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: